Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4330)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java

Issue 2984453002: Add Browser Actions tab model selector and open a tab through it if ChromeTabbedActivity is not ava…
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java
index f40cc273a8973026586536fd723f530139b0f67e..2774b19205e415cdc2677ff1144521b4f9aeb8bf 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java
@@ -61,12 +61,17 @@ public interface TabModel extends TabList {
FROM_LAUNCHER_SHORTCUT,
/**
- * The tab is initially detached.
+ * The tab is initially detached from CCT.
*/
- FROM_DETACHED,
+ FROM_DETACHED_SPECULATE,
/** Opened in the background from Browser Actions context menu. */
FROM_BROWSER_ACTIONS,
+
+ /**
+ * The tab is initially detached explicitly by users.
+ */
+ FROM_DETACHED_USER_ACTION,
Yusuf 2017/07/18 22:59:47 how is this different from the new launch type we
ltian 2017/08/07 23:24:12 Revert it back since new design creates all tabs i
}
/**

Powered by Google App Engine
This is Rietveld 408576698