Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 298443002: Remove unused support for SysV shared memory (Closed)

Created:
6 years, 7 months ago by Mark Seaborn
Modified:
6 years, 7 months ago
Reviewers:
sehr, bradn
CC:
native-client-reviews_googlegroups.com, jln (very slow on Chromium), sehr
Visibility:
Public.

Description

Remove unused support for SysV shared memory Chromium no longer uses this. It used to be that the renderer and NaCl processes would share SysV shared memory segments with the X11 server on Linux (because the MIT-SHM extension to X11 relies on SysV shared memory). However, with Chromium switching to new compositing methods, the sandboxed processes no longer share memory with the X server. Chromium's reference to NaCl's ImportSysvShm() was removed in January 2013: https://src.chromium.org/viewvc/chrome?revision=177732&view=revision * Remove NaClDesc type for SysV shared memory segments. * SConstruct: Remove reference to non-existent run_srpc_sysv_shm_test. * Remove platform qualification test that tests SysV SHM. This will allow Chromium's seccomp-bpf sandbox for NaCl processes to be tightened up to disallow use of SysV SHM. * Remove AddressMap (dead code) from sel_universal. BUG=none TEST=NaCl trybots + Chromium Linux trybot R=sehr@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -950 lines) Patch
M SConstruct View 1 chunk +0 lines, -5 lines 0 comments Download
M src/trusted/desc/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download
M src/trusted/desc/build.scons View 1 chunk +0 lines, -3 lines 0 comments Download
M src/trusted/desc/desc.gyp View 1 chunk +1 line, -6 lines 0 comments Download
D src/trusted/desc/linux/nacl_desc_sysv_shm.h View 1 chunk +0 lines, -74 lines 0 comments Download
D src/trusted/desc/linux/nacl_desc_sysv_shm.c View 1 chunk +0 lines, -430 lines 0 comments Download
M src/trusted/desc/nacl_desc_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/trusted/desc/nacl_desc_base.c View 3 chunks +0 lines, -9 lines 0 comments Download
M src/trusted/desc/nacl_desc_wrapper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/trusted/desc/nacl_desc_wrapper.cc View 2 chunks +0 lines, -34 lines 0 comments Download
M src/trusted/platform_qualify/build.scons View 1 chunk +0 lines, -2 lines 0 comments Download
M src/trusted/platform_qualify/linux/nacl_os_qualify.c View 2 chunks +0 lines, -9 lines 0 comments Download
D src/trusted/platform_qualify/linux/sysv_shm_and_mmap.h View 1 chunk +0 lines, -24 lines 0 comments Download
D src/trusted/platform_qualify/linux/sysv_shm_and_mmap.c View 1 chunk +0 lines, -245 lines 0 comments Download
M src/trusted/platform_qualify/platform_qualify.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/trusted/platform_qualify/posix/nacl_dep_qualify.c View 1 chunk +0 lines, -1 line 0 comments Download
M src/trusted/sel_universal/rpc_universal.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/trusted/sel_universal/rpc_universal_system.cc View 2 chunks +0 lines, -38 lines 0 comments Download
M src/trusted/service_runtime/include/bits/stat.h View 3 chunks +1 line, -9 lines 0 comments Download
M src/trusted/service_runtime/mmap_unittest.cc View 2 chunks +0 lines, -48 lines 0 comments Download
M src/trusted/service_runtime/sys_memory.c View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Seaborn
6 years, 7 months ago (2014-05-19 19:52:33 UTC) #1
sehr
lgtm
6 years, 7 months ago (2014-05-19 20:29:03 UTC) #2
Mark Seaborn
Committed patchset #1 manually as r13208 (presubmit successful).
6 years, 7 months ago (2014-05-19 21:03:24 UTC) #3
bradn
6 years, 7 months ago (2014-05-19 21:42:57 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698