Include platform.dill files in sdk builds

Include platform.dill files in sdk builds

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/de7e14436c57649e5786c7aa60660c1959ff6975

[Siggi Cherem (dart-lang), 2017-07-26 04:46:41]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2017-07-26 04:51:55]

sigmund@google.com changed reviewers:
+ whesse@google.com, zra@google.com

[Siggi Cherem (dart-lang), 2017-07-26 04:51:56]

As we start using the shared FE on our tools, we want to ship with the
precompiled kernel code for the sdk libraries, that way we don't waste user's
time recompiling it over and over.

For the vm - we only need an outline of the sdk to perform resolution, because
the VM will embed these libraries in it's snapshot (although this is not
implemented yet today on the kernel pipeline)

For dart2js - we need the full sdk sources to perform whole program
optimizations. We already ship the dart2js sdk patch files under
_internal/js_runtime, but we could potentially not include them there anymore.

Note: the web_full.dill embeds the Dart sources as well, we might move away from
this design choice in kernel, but for now that means we are shipping the
contents of the Dart sources twice. If this is an issue, we can truncate the
.dill files.

https://codereview.chromium.org/2984243002/diff/20001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/2984243002/diff/20001/BUILD.gn#oldcode114
BUILD.gn:114: "utils/compiler:patched_dart2js_sdk",
I had just added this yesterday thinking this is all I needed to get some bots
to run the dart2js tests using the shared frontend. I didn't realize that those
bots are not building the sdk, so this had no effect on those bots.

https://codereview.chromium.org/2984243002/diff/20001/sdk/BUILD.gn
File sdk/BUILD.gn (right):

https://codereview.chromium.org/2984243002/diff/20001/sdk/BUILD.gn#newcode68
sdk/BUILD.gn:68: #.........web_full.dill
I've been debating the names here, and I'm not even convinced of my current
choice. Let me know if you any suggestions or preferences.

The names I've considered:
 - vm_outline & dart2js_platform (& possibly ddc_platform one day)
 - vm_platform & dart2js_full 
 - server_outline & web_platform
 - vm_summary (summary is a name we use in the FE public APIs) & dart2js_full
 - vm_sdk_summary.dill, dart2js_sdk.dill

At this moment I'm not sure if dart2js and ddc will be able to share the same
code for the sdk libraries. If they do, "web" is a better choice.

[zra, 2017-07-26 05:04:58]

https://codereview.chromium.org/2984243002/diff/20001/sdk/BUILD.gn
File sdk/BUILD.gn (right):

https://codereview.chromium.org/2984243002/diff/20001/sdk/BUILD.gn#newcode455
sdk/BUILD.gn:455: ":copy_dart2js_dill_files",
The "platform" SDK shouldn't include the dart2js dill file. Instead,
create_common_sdk should depend on copy_vm_dill_files, and create_full_sdk
should depend on copy_dart2js_dill_files.

[Siggi Cherem (dart-lang), 2017-07-26 19:52:39]

PTAL

https://codereview.chromium.org/2984243002/diff/20001/sdk/BUILD.gn
File sdk/BUILD.gn (right):

https://codereview.chromium.org/2984243002/diff/20001/sdk/BUILD.gn#newcode68
sdk/BUILD.gn:68: #.........web_full.dill
On 2017/07/26 04:51:56, Siggi Cherem (dart-lang) wrote:
> I've been debating the names here, and I'm not even convinced of my current
> choice. Let me know if you any suggestions or preferences.
> 
> The names I've considered:
>  - vm_outline & dart2js_platform (& possibly ddc_platform one day)
>  - vm_platform & dart2js_full 
>  - server_outline & web_platform
>  - vm_summary (summary is a name we use in the FE public APIs) & dart2js_full
>  - vm_sdk_summary.dill, dart2js_sdk.dill
> 
> At this moment I'm not sure if dart2js and ddc will be able to share the same
> code for the sdk libraries. If they do, "web" is a better choice.

I continued iterating on this - I decided for now to keep the outline/platform
suffixes and use the target name as a prefix. We can iterate on this more
afterwards.

  vm_outline.dill
  dart2js_platform.dill

https://codereview.chromium.org/2984243002/diff/20001/sdk/BUILD.gn#newcode455
sdk/BUILD.gn:455: ":copy_dart2js_dill_files",
On 2017/07/26 05:04:58, zra wrote:
> The "platform" SDK shouldn't include the dart2js dill file. Instead,
> create_common_sdk should depend on copy_vm_dill_files, and create_full_sdk
> should depend on copy_dart2js_dill_files.

Thanks Zach. Done.

[Siggi Cherem (dart-lang), 2017-07-26 19:53:21]

Patchset #2 (id:40001) has been deleted

[zra, 2017-07-26 21:23:43]

zra@google.com changed reviewers:
+ asiva@google.com

[zra, 2017-07-26 21:23:44]

+asiva

lgtm with nits

Also, Siva was wondering if this CL should also include the .dill for the
front-end in the SDK.

https://codereview.chromium.org/2984243002/diff/60001/sdk/BUILD.gn
File sdk/BUILD.gn (right):

https://codereview.chromium.org/2984243002/diff/60001/sdk/BUILD.gn#newcode739
sdk/BUILD.gn:739: ":copy_vm_dill_files",
nit: Please keep this list alphabetized.

https://codereview.chromium.org/2984243002/diff/60001/sdk/BUILD.gn#newcode775
sdk/BUILD.gn:775: ":copy_dart2js_dill_files",
ditto

[Siggi Cherem (dart-lang), 2017-07-26 21:46:21]

Thanks Zach!

Siva - I'm not sure exactly what you have in mind. Would this be the FE code so
it can be used in flutter_tools?

Currently we are shipping that code under sdk/lib/front_end (it was needed to
ship analyzer in the same way for flutter tools).

I'll start landing this change for now, but I'm happy to follow up with a second
change for FE if that's not what you were after.

https://codereview.chromium.org/2984243002/diff/60001/sdk/BUILD.gn
File sdk/BUILD.gn (right):

https://codereview.chromium.org/2984243002/diff/60001/sdk/BUILD.gn#newcode739
sdk/BUILD.gn:739: ":copy_vm_dill_files",
On 2017/07/26 21:23:44, zra wrote:
> nit: Please keep this list alphabetized.

Done.

https://codereview.chromium.org/2984243002/diff/60001/sdk/BUILD.gn#newcode775
sdk/BUILD.gn:775: ":copy_dart2js_dill_files",
On 2017/07/26 21:23:44, zra wrote:
> ditto

Done.

[Siggi Cherem (dart-lang), 2017-07-26 21:50:54]

Description was changed from

==========
Include platform.dill files in sdk builds
==========

to

==========
Include platform.dill files in sdk builds

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/de7e14436c57649e5786c7aa60660c1959ff6975
==========

[Siggi Cherem (dart-lang), 2017-07-26 21:50:55]

Committed patchset #3 (id:80001) manually as
de7e14436c57649e5786c7aa60660c1959ff6975 (presubmit successful).