Include platform.dill files in sdk builds

sdk/BUILD.gn

 # Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 # This GN file contains build rules for assembling the Dart SDK. There are
 # two possible variants: the "Full" SDK, and the "Platform" SDK. If you want
 # to make a new subset of the Full SDK, make it the same way we make
 # the Platform SDK.
 #
 # Warning:
@@ skipping 47 matching lines @@
 # ......dart_mirrors_api.h
 # ......dart_native_api.h
 # ......dart_tools_api.h
 # ....lib/
 # ......dart_client.platform
 # ......dart_server.platform
 # ......dart_shared.platform
 # ......_internal/
 #.........spec.sum
 #.........strong.sum
+#.........web_full.dill

[Siggi Cherem (dart-lang), 2017/07/26 04:51:56]

I've been debating the names here, and I'm not even convinced of my current
choice. Let me know if you any suggestions or preferences.

The names I've considered:
 - vm_outline & dart2js_platform (& possibly ddc_platform one day)
 - vm_platform & dart2js_full 
 - server_outline & web_platform
 - vm_summary (summary is a name we use in the FE public APIs) & dart2js_full
 - vm_sdk_summary.dill, dart2js_sdk.dill

At this moment I'm not sure if dart2js and ddc will be able to share the same
code for the sdk libraries. If they do, "web" is a better choice.

[Siggi Cherem (dart-lang), 2017/07/26 19:52:39]

I continued iterating on this - I decided for now to keep the outline/platform
suffixes and use the target name as a prefix. We can iterate on this more
afterwards.

  vm_outline.dill
  dart2js_platform.dill

+#.........server_outline.dill
 #.........dev_compiler/
 # ......analysis_server/
 # ......analyzer/
 # ......async/
 # ......collection/
 # ......convert/
 # ......core/
 # ......front_end/
 # ......html/
 # ......internal/
@@ skipping 359 matching lines @@
   ]
   sources = [
     "$root_gen_dir/spec.sum",
     "$root_gen_dir/strong.sum",
   ]
   outputs = [
     "$root_out_dir/dart-sdk/lib/_internal/{{source_file_part}}",
   ]
 }
 
+# This rule copies .dill files to lib/_internal
+group("copy_dill_files") {
+  visibility = [ ":create_common_sdk" ]
+  deps = [
+    ":copy_libraries",
+    ":copy_vm_dill_files",
+    ":copy_dart2js_dill_files",

[zra, 2017/07/26 05:04:58]

The "platform" SDK shouldn't include the dart2js dill file. Instead,
create_common_sdk should depend on copy_vm_dill_files, and create_full_sdk
should depend on copy_dart2js_dill_files.

[Siggi Cherem (dart-lang), 2017/07/26 19:52:39]

Thanks Zach. Done.

+  ]
+}
+
+copy("copy_vm_dill_files") {
+  visibility = [ ":copy_dill_files" ]
+  deps = [
+    ":copy_libraries",
+    "../runtime/vm:patched_sdk",
+  ]
+  sources = [
+    "$root_out_dir/patched_sdk/outline.dill",
+  ]
+  outputs = [
+    "$root_out_dir/dart-sdk/lib/_internal/server_{{source_file_part}}",
+  ]
+}
+
+copy("copy_dart2js_dill_files") {
+  visibility = [ ":copy_dill_files" ]
+  deps = [
+    ":copy_libraries",
+    "../utils/compiler:patched_dart2js_sdk",
+  ]
+  sources = [
+    "$root_out_dir/patched_dart2js_sdk/platform.dill",
+  ]
+  outputs = [
+    "$root_out_dir/dart-sdk/lib/_internal/web_full.dill",
+  ]
+}
+
 # This rule copies ddc summaries to lib/_internal
 copy("copy_dev_compiler_summary") {
   visibility = [ ":copy_dev_compiler_sdk" ]
   deps = [
     ":copy_libraries",
   ]
   sources = [
     "../pkg/dev_compiler/lib/sdk/ddc_sdk.sum",
   ]
   outputs = [
@@ skipping 240 matching lines @@
 
 # Parts common to both platform and full SDKs.
 group("create_common_sdk") {
   visibility = [ ":create_sdk" ]
   deps = [
     ":copy_analysis_summaries",
     ":copy_analyzer_sources",
     ":copy_api_readme",
     ":copy_dart",
     ":copy_dartdoc_files",
+    ":copy_dill_files",
     ":copy_headers",
     ":copy_libraries_dart",
     ":copy_license",
     ":copy_platform_files",
     ":copy_pub_assets",
     ":copy_readme",
     ":write_revision_file",
     ":write_version_file",
   ]
   if (is_win) {
@@ skipping 32 matching lines @@
 group("create_sdk") {
   deps = [
     ":create_common_sdk",
   ]
   if (dart_platform_sdk) {
     deps += [ ":create_platform_sdk" ]
   } else {
     deps += [ ":create_full_sdk" ]
   }
 }