Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2984203002: Move the status file parser into its own package. (Closed)

Created:
3 years, 5 months ago by Bob Nystrom
Modified:
3 years, 5 months ago
Reviewers:
bkonyi, Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move the status file parser into its own package. This required munging a bit of test.dart code too to tease out some dependencies, but the changes are minor. I considered moving all of test.dart out into a package and making the status file library a public one that other packages in the repo could import but this seemed like the less intrusive change. R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/796eb2107128c0ea7e10f8aaacb870a32e737b31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -931 lines) Patch
M .packages View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/pkg.status View 1 chunk +3 lines, -0 lines 0 comments Download
A pkg/status_file/.packages View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/status_file/lib/environment.dart View 1 chunk +16 lines, -0 lines 0 comments Download
A + pkg/status_file/lib/expectation.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/status_file/lib/src/expression.dart View 5 chunks +10 lines, -10 lines 0 comments Download
A + pkg/status_file/lib/status_file.dart View 7 chunks +56 lines, -26 lines 0 comments Download
A pkg/status_file/pubspec.yaml View 1 chunk +12 lines, -0 lines 0 comments Download
A pkg/status_file/test/repo_status_files_test.dart View 1 chunk +36 lines, -0 lines 0 comments Download
A + pkg/status_file/test/status_expression_test.dart View 1 chunk +7 lines, -3 lines 0 comments Download
D tests/standalone/io/status_file_parser_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
M tests/standalone/io/test_runner_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -2 lines 0 comments Download
D tests/standalone/status_expression_test.dart View 1 chunk +0 lines, -124 lines 0 comments Download
M tools/testing/dart/command.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tools/testing/dart/command_output.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tools/testing/dart/environment.dart View 3 chunks +9 lines, -7 lines 0 comments Download
D tools/testing/dart/expectation.dart View 1 chunk +0 lines, -211 lines 0 comments Download
M tools/testing/dart/expectation_set.dart View 2 chunks +23 lines, -12 lines 0 comments Download
D tools/testing/dart/status_expression.dart View 1 chunk +0 lines, -292 lines 0 comments Download
D tools/testing/dart/status_file.dart View 1 chunk +0 lines, -198 lines 0 comments Download
M tools/testing/dart/summary_report.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tools/testing/dart/test_progress.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tools/testing/dart/test_runner.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
As a side-effect, the status_file package uses the path package instead of the copy of ...
3 years, 5 months ago (2017-07-25 01:13:06 UTC) #2
bkonyi
LGTM
3 years, 5 months ago (2017-07-25 15:44:17 UTC) #3
Bob Nystrom
3 years, 5 months ago (2017-07-25 22:30:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
796eb2107128c0ea7e10f8aaacb870a32e737b31 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698