Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Side by Side Diff: tools/testing/dart/command_output.dart

Issue 2984203002: Move the status file parser into its own package. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/testing/dart/command.dart ('k') | tools/testing/dart/environment.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:convert'; 5 import 'dart:convert';
6 // We need to use the 'io' prefix here, otherwise io.exitCode will shadow 6 // We need to use the 'io' prefix here, otherwise io.exitCode will shadow
7 // CommandOutput.exitCode in subclasses of CommandOutput. 7 // CommandOutput.exitCode in subclasses of CommandOutput.
8 import 'dart:io' as io; 8 import 'dart:io' as io;
9 9
10 import 'package:status_file/expectation.dart';
11
10 import 'browser_controller.dart'; 12 import 'browser_controller.dart';
11 import 'command.dart'; 13 import 'command.dart';
12 import 'configuration.dart'; 14 import 'configuration.dart';
13 import 'expectation.dart';
14 import 'test_runner.dart'; 15 import 'test_runner.dart';
15 import 'utils.dart'; 16 import 'utils.dart';
16 17
17 /// CommandOutput records the output of a completed command: the process's exit 18 /// CommandOutput records the output of a completed command: the process's exit
18 /// code, the standard output and standard error, whether the process timed out, 19 /// code, the standard output and standard error, whether the process timed out,
19 /// and the time the process took to run. It does not contain a pointer to the 20 /// and the time the process took to run. It does not contain a pointer to the
20 /// [TestCase] this is the output of, so some functions require the test case 21 /// [TestCase] this is the output of, so some functions require the test case
21 /// to be passed as an argument. 22 /// to be passed as an argument.
22 class CommandOutput extends UniqueObject { 23 class CommandOutput extends UniqueObject {
23 final Command command; 24 final Command command;
(...skipping 806 matching lines...) Expand 10 before | Expand all | Expand 10 after
830 // complete successfully, it's outcome is Expectation.FAIL. 831 // complete successfully, it's outcome is Expectation.FAIL.
831 // TODO: maybe we should introduce a AsyncIncomplete marker or so 832 // TODO: maybe we should introduce a AsyncIncomplete marker or so
832 if (outcome == Expectation.pass) { 833 if (outcome == Expectation.pass) {
833 if (_isAsyncTest(testOutput) && !_isAsyncTestSuccessful(testOutput)) { 834 if (_isAsyncTest(testOutput) && !_isAsyncTestSuccessful(testOutput)) {
834 return Expectation.fail; 835 return Expectation.fail;
835 } 836 }
836 } 837 }
837 return outcome; 838 return outcome;
838 } 839 }
839 } 840 }
OLDNEW
« no previous file with comments | « tools/testing/dart/command.dart ('k') | tools/testing/dart/environment.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698