Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2984023002: Rename buttons for voice interaction value prop screen (Closed)

Created:
3 years, 5 months ago by yueli
Modified:
3 years, 5 months ago
Reviewers:
Alexander Alekseev, xc
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename buttons for voice interaction value prop screen - Rename the 'no thanks' and 'continue' buttons to 'skip' and 'next'. - Refactor the code. BUG=b/63909126 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2984023002 Cr-Commit-Position: refs/heads/master@{#488741} Committed: https://chromium.googlesource.com/chromium/src/+/2cd0fcc10460bbbdf65c73a820bb5bff3ae0f074

Patch Set 1 #

Messages

Total messages: 13 (9 generated)
yueli
PTAL
3 years, 5 months ago (2017-07-21 01:32:11 UTC) #3
Alexander Alekseev
lgtm
3 years, 5 months ago (2017-07-21 01:41:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2984023002/1
3 years, 5 months ago (2017-07-21 20:14:45 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-21 20:22:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2cd0fcc10460bbbdf65c73a820bb...

Powered by Google App Engine
This is Rietveld 408576698