Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1725)

Issue 2983953002: Revert of Last_n: instrumentation tests to verify timely snapshot deletion. (Closed)

Created:
3 years, 5 months ago by jdoerrie
Modified:
3 years, 5 months ago
Reviewers:
carlosk, dewittj
CC:
chromium-reviews, David Trainor- moved to gerrit
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Last_n: instrumentation tests to verify timely snapshot deletion. (patchset #7 id:120001 of https://codereview.chromium.org/2833653002/ ) Reason for revert: Likely cause of https://crbug.com/746699. testLastNPageIsDeletedUponNavigation is flaky. Original issue's description: > Last_n: instrumentation tests to verify timely snapshot deletion. > > Adds new tests to RecentTabsTest.java to verify that offline snapshots created > by last_n are properly deleted when successfully navigating to another page and > upon tab closure. These actions are important to comply with privacy > requirements for this feature. > > This change re-adds instrumentation tests previously committed along with a > related bugfix [1] that were reverted due to them being flaky. It seems that the > underlying issue causing the flakyness has been fixed [2] [3] so these should > now work as expected. > > [1] https://codereview.chromium.org/2824623002/ > [2] https://bugs.chromium.org/p/chromium/issues/detail?id=592961 (restricted) > [3] https://bugs.chromium.org/p/chromium/issues/detail?id=738490 > > BUG=711770 > > Review-Url: https://codereview.chromium.org/2833653002 > Cr-Commit-Position: refs/heads/master@{#487727} > Committed: https://chromium.googlesource.com/chromium/src/+/f6fd25d5826f1a62010b08037eb50c396b05d7a2 TBR=dewittj@chromium.org,carlosk@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=711770 Review-Url: https://codereview.chromium.org/2983953002 Cr-Commit-Position: refs/heads/master@{#488195} Committed: https://chromium.googlesource.com/chromium/src/+/3455deb988f259fde5248f926196057fa19bcb4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -144 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/RecentTabsTest.java View 11 chunks +14 lines, -142 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jdoerrie
Created Revert of Last_n: instrumentation tests to verify timely snapshot deletion.
3 years, 5 months ago (2017-07-20 09:47:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2983953002/1
3 years, 5 months ago (2017-07-20 09:47:34 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-20 11:24:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3455deb988f259fde5248f926196...

Powered by Google App Engine
This is Rietveld 408576698