Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2983893002: Simpified Gesture Nav: Don't navigate if affordance isn't showing. (Closed)

Created:
3 years, 5 months ago by mfomitchev
Modified:
3 years, 5 months ago
Reviewers:
mohsen
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simpified Gesture Nav: Don't navigate if affordance isn't showing. If navigation isn't possible when GestureNavSimple::OnOverscrollModeChange is called, we don't show the affordance. In this case, we shouldn't attempt to navigate again when GestureNavSimple::OnOverscrollComplete is called (even if we can). BUG=NONE Review-Url: https://codereview.chromium.org/2983893002 Cr-Commit-Position: refs/heads/master@{#488290} Committed: https://chromium.googlesource.com/chromium/src/+/4ef16e68fa52bcd09eed82c3ee4c32f29aa64279

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/browser/web_contents/aura/gesture_nav_simple.cc View 1 2 chunks +4 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (13 generated)
mfomitchev
Mohsen, can you PTAL?
3 years, 5 months ago (2017-07-20 02:05:56 UTC) #11
mohsen
lgtm
3 years, 5 months ago (2017-07-20 15:43:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2983893002/20001
3 years, 5 months ago (2017-07-20 17:29:12 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-07-20 17:33:12 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4ef16e68fa52bcd09eed82c3ee4c...

Powered by Google App Engine
This is Rietveld 408576698