Resynthesize expressions for Kernel's StaticGet and PropertyGet.

Resynthesize expressions for Kernel's StaticGet and PropertyGet.

Note, that we don't restore the original AST for StaticGet(s).
The original AST is not available in Kernel.
Instead we generate simple identifiers with correct elements.
It should be enough to compute constant values, although some clients
might have to adapt to the change.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/9d5a249ed395a45ef4855f0942043e68434ff44e

[Paul Berry, 2017-07-18 18:00:14]

https://codereview.chromium.org/2983773002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_common.dart (right):

https://codereview.chromium.org/2983773002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_common.dart:3613: F/*location:
test.dart;C;F?*/.
I'm ok with not resynthesizing identifiers associated with an import prefix, but
it seems weird that we wouldn't resynthesize "C." here, since "C" is a class,
and there's no conceivable set of imports that would make this AST correct. 
IMHO it places un undue burden on clients to require them to deal with this
case.

How difficult would it be if, during resynthesis of the constant, we checked
whether the parent element was a class, and if so, resynthesize "ClassName."
before the identifier?

[scheglov, 2017-07-18 19:01:12]

PTAL

https://codereview.chromium.org/2983773002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_common.dart (right):

https://codereview.chromium.org/2983773002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_common.dart:3613: F/*location:
test.dart;C;F?*/.
On 2017/07/18 18:00:14, Paul Berry wrote:
> I'm ok with not resynthesizing identifiers associated with an import prefix,
but
> it seems weird that we wouldn't resynthesize "C." here, since "C" is a class,
> and there's no conceivable set of imports that would make this AST correct. 
> IMHO it places un undue burden on clients to require them to deal with this
> case.
> 
> How difficult would it be if, during resynthesis of the constant, we checked
> whether the parent element was a class, and if so, resynthesize "ClassName."
> before the identifier?

Done.

[Paul Berry, 2017-07-18 19:35:42]

lgtm

[scheglov, 2017-07-18 20:09:21]

Description was changed from

==========
Resynthesize expressions for Kernel's StaticGet and PropertyGet.

Note, that we don't restore the original AST for StaticGet(s).
The original AST is not available in Kernel.
Instead we generate simple identifiers with correct elements.
It should be enough to compute constant values, although some clients
might have to adapt to the change.

R=paulberry@google.com
BUG=
==========

to

==========
Resynthesize expressions for Kernel's StaticGet and PropertyGet.

Note, that we don't restore the original AST for StaticGet(s).
The original AST is not available in Kernel.
Instead we generate simple identifiers with correct elements.
It should be enough to compute constant values, although some clients
might have to adapt to the change.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/9d5a249ed395a45ef4855f0942043e68434ff44e
==========

[scheglov, 2017-07-18 20:09:22]

Committed patchset #2 (id:20001) manually as
9d5a249ed395a45ef4855f0942043e68434ff44e (presubmit successful).