Resynthesize expressions for Kernel's StaticGet and PropertyGet.

pkg/analyzer/test/src/summary/resynthesize_common.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.src.serialization.elements_test;
 
 import 'dart:async';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/standard_resolution_map.dart';
@@ skipping 51 matching lines @@
    * Tests may set this to `false` to indicate that resynthesized elements
    * should not be compare with elements created using AnalysisContext.
    */
   bool shouldCompareLibraryElements = true;
 
   /**
    * Return `true` if resynthesizing should be done is strong mode.
    */
   bool get isStrongMode;
 
+  /**
+   * Return `true` if shared front-end is used.
+   */
+  bool get isSharedFrontEnd => false;
+
   void addLibrary(String uri) {
     otherLibrarySources.add(context.sourceFactory.forUri(uri));
   }
 
   Source addLibrarySource(String filePath, String contents) {
     Source source = addSource(filePath, contents);
     otherLibrarySources.add(source);
     return source;
   }
 
@@ skipping 3510 matching lines @@
   }
 
   test_const_length_ofClassConstField() async {
     var library = await checkLibrary(r'''
 class C {
   static const String F = '';
 }
 const int v = C.F.length;
 ''');
     if (isStrongMode) {
-      checkElementText(library, r'''
+      if (isSharedFrontEnd) {
+        checkElementText(library, r'''
 class C {
   static const String F = '';
 }
+const int v =
+        F/*location: test.dart;C;F?*/.

[Paul Berry, 2017/07/18 18:00:14]

I'm ok with not resynthesizing identifiers associated with an import prefix, but
it seems weird that we wouldn't resynthesize "C." here, since "C" is a class,
and there's no conceivable set of imports that would make this AST correct. 
IMHO it places un undue burden on clients to require them to deal with this
case.

How difficult would it be if, during resynthesis of the constant, we checked
whether the parent element was a class, and if so, resynthesize "ClassName."
before the identifier?

[scheglov, 2017/07/18 19:01:11]

Done.

+        length/*location: dart:core;String;length?*/;
+''');
+      } else {
+        checkElementText(library, r'''
+class C {
+  static const String F = '';
+}
 const int v =
         C/*location: test.dart;C*/.
         F/*location: test.dart;C;F?*/.
         length/*location: dart:core;String;length?*/;
 ''');
+      }
     } else {
       checkElementText(library, r'''
 class C {
   static const String F = '';
 }
 const int v =
         C/*location: test.dart;C*/.
         F/*location: test.dart;C;F?*/.
         length/*location: dart:core;String;length?*/;
 ''');
@@ skipping 58 matching lines @@
         length/*location: dart:core;String;length?*/;
 ''');
     }
   }
 
   test_const_length_ofStringLiteral() async {
     var library = await checkLibrary(r'''
 const v = 'abc'.length;
 ''');
     if (isStrongMode) {
-      checkElementText(library, r'''
+      if (isSharedFrontEnd) {
+        checkElementText(library, r'''
+const int v = 'abc'.
+        length/*location: dart:core;String;length?*/;
+''');
+      } else {
+        checkElementText(library, r'''
 const dynamic v/*error: instanceGetter*/ = 'abc'.
         length/*location: dart:core;String;length?*/;
 ''');
+      }
     } else {
       checkElementText(library, r'''
 const dynamic v = 'abc'.
         length/*location: dart:core;String;length?*/;
 ''');
     }
   }
 
   test_const_length_ofTopLevelVariable() async {
     var library = await checkLibrary(r'''
 const String S = 'abc';
 const v = S.length;
 ''');
     if (isStrongMode) {
-      checkElementText(library, r'''
+      if (isSharedFrontEnd) {
+        checkElementText(library, r'''
+const String S = 'abc';
+const int v =
+        S/*location: test.dart;S?*/.
+        length/*location: dart:core;String;length?*/;
+''');
+      } else {
+        checkElementText(library, r'''
 const String S = 'abc';
 const dynamic v/*error: instanceGetter*/ =
         S/*location: test.dart;S?*/.
         length/*location: dart:core;String;length?*/;
 ''');
+      }
     } else {
       checkElementText(library, r'''
 const String S = 'abc';
 const dynamic v =
         S/*location: test.dart;S?*/.
         length/*location: dart:core;String;length?*/;
 ''');
     }
   }
 
@@ skipping 9428 matching lines @@
       fail('Unexpectedly tried to get unlinked summary for $uri');
     }
     return serializedUnit;
   }
 
   @override
   bool hasLibrarySummary(String uri) {
     return true;
   }
 }