media: Add UMA stats for bytes going in and out of multibuffer cache

media: Add UMA stats for bytes going in and out of multibuffer cache

This will help us diagnose regressions which cause us to read more data than we need.

BUG=738595
Review-Url: https://codereview.chromium.org/2983733002
Cr-Commit-Position: refs/heads/master@{#490024}
Committed: https://chromium.googlesource.com/chromium/src/+/94d248f20319c705b7fda1f2074515c72b053485

[hubbe, 2017-07-17 22:40:07]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-17 22:40:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hubbe, 2017-07-17 22:40:22]

hubbe@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2017-07-17 22:56:30]

lgtm, thanks! You should switch to gerrit for future CLs now though.

[hubbe, 2017-07-17 22:58:40]

hubbe@chromium.org changed reviewers:
+ holte@chromium.org

[hubbe, 2017-07-17 22:58:41]

+holte for histograms.xml

[commit-bot: I haz the power, 2017-07-18 03:51:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-18 03:51:41]

Dry run: This issue passed the CQ dry run.

[hubbe, 2017-07-18 18:29:04]

hubbe@chromium.org changed reviewers:
+ rkaplow@chromium.org

[hubbe, 2017-07-18 18:29:04]

trying rkaplow for histograms.xml

[rkaplow1, 2017-07-18 18:54:04]

rkaplow@google.com changed reviewers:
+ rkaplow@google.com

[rkaplow1, 2017-07-18 18:54:05]

lgtm

https://codereview.chromium.org/2983733002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2983733002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:29252: +  <summary>Kb read by media
demuxer from MultiBuffer cache.</summary>
may want to make it more clear when this is recorded.

[rkaplow, 2017-07-19 14:35:59]

lgtm

giving lg with proper account

[hubbe, 2017-07-19 18:00:54]

The CQ bit was checked by hubbe@chromium.org

[hubbe, 2017-07-19 18:00:58]

https://codereview.chromium.org/2983733002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2983733002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:29252: +  <summary>Kb read by media
demuxer from MultiBuffer cache.</summary>
On 2017/07/18 18:54:05, rkaplow1 wrote:
> may want to make it more clear when this is recorded.

It's not an easy thing to explain succinctly.
(As is often the case when you have a cache with lazy eviction..)

[commit-bot: I haz the power, 2017-07-19 18:01:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-19 19:09:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-19 19:09:52]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[hubbe, 2017-07-26 23:11:04]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2017-07-26 23:11:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-27 00:15:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-27 00:15:22]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hubbe, 2017-07-27 00:39:08]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2017-07-27 00:39:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-27 08:03:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-27 08:03:36]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hubbe, 2017-07-27 19:40:05]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2017-07-27 19:40:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-27 22:40:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1501184405234420, "parent_rev":
"043eb1cbee9cfaddb4e98b4c1a70ada2de99f040", "commit_rev":
"94d248f20319c705b7fda1f2074515c72b053485"}

[commit-bot: I haz the power, 2017-07-27 22:41:22]

Description was changed from

==========
media: Add UMA stats for bytes going in and out of multibuffer cache

This will help us diagnose regressions which cause us to read more data than we
need.

BUG=738595
==========

to

==========
media: Add UMA stats for bytes going in and out of multibuffer cache

This will help us diagnose regressions which cause us to read more data than we
need.

BUG=738595

Review-Url: https://codereview.chromium.org/2983733002
Cr-Commit-Position: refs/heads/master@{#490024}
Committed:
https://chromium.googlesource.com/chromium/src/+/94d248f20319c705b7fda1f20745...
==========

[commit-bot: I haz the power, 2017-07-27 22:41:24]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/94d248f20319c705b7fda1f20745...