Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2983493002: config_service: make UI responsive and change colors. (Closed)

Created:
3 years, 5 months ago by ayanaadylova
Modified:
3 years, 5 months ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

config_service: make UI responsive and change colors. Add colors, fix word-wrap. Adjust header and make UI responsive. BUG=740775 Review-Url: https://codereview.chromium.org/2983493002 Committed: https://github.com/luci/luci-py/commit/dc53549f921bcf9acc826ef43baba70635182af2

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move styles to the <style> section. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -85 lines) Patch
M appengine/config_service/ui/common/auth-signin.html View 1 chunk +4 lines, -1 line 0 comments Download
M appengine/config_service/ui/src/config-ui/config-file-card.html View 1 chunk +4 lines, -2 lines 0 comments Download
M appengine/config_service/ui/src/config-ui/config-set.html View 1 4 chunks +21 lines, -9 lines 0 comments Download
M appengine/config_service/ui/src/config-ui/config-set-card.html View 1 2 chunks +20 lines, -8 lines 0 comments Download
M appengine/config_service/ui/src/config-ui/config-ui.html View 2 chunks +75 lines, -64 lines 0 comments Download
M appengine/config_service/ui/src/config-ui/front-page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
ayanaadylova
PTAL Link to the staging version: https://2963-4d627a5-tainted-ayanaadylova-dot-luci-config.appspot.com/newui
3 years, 5 months ago (2017-07-13 17:28:18 UTC) #2
Sergey Berezin
LGTM, assuming the existing tests still pass. Very nice, thank you! I don't have any ...
3 years, 5 months ago (2017-07-13 19:06:54 UTC) #3
Ryan Tseng
This looks really good! lgtm Some things i'd add (in a separate CL): * Alt/Hover ...
3 years, 5 months ago (2017-07-13 22:16:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2983493002/20001
3 years, 5 months ago (2017-07-13 23:23:19 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-13 23:25:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/dc53549f921bcf9acc826ef43baba70635182af2

Powered by Google App Engine
This is Rietveld 408576698