Make chrome --mus run the UI Service inside the browser process.

Make chrome --mus run the UI Service inside the browser process.

This CL takes advantage of the mechanisms introduced in
https://codereview.chromium.org/2979933002/ to run the UI Service inside the
browser process in Mushrome (i.e. when chrome is launched with --mus parameter).

UI Service runs on a separate thread with high priority. For now both the UI
Service and the GPU Service are moved. Once WS/GPU split if finished, GPU will
need to be moved into its separate process.

CrOS BrowserProcessPlatformPart owns the ImageCursorsSet used by the UI Service
for cursor manipulation.

BUG=722527
Review-Url: https://codereview.chromium.org/2983443002
Cr-Commit-Position: refs/heads/master@{#486688}
Committed: https://chromium.googlesource.com/chromium/src/+/a872e762ddd650e53e093a4c68342eb637d5a931

[mfomitchev, 2017-07-13 02:45:50]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-13 02:46:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-13 02:49:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-13 02:49:40]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mfomitchev, 2017-07-13 03:12:42]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-13 03:13:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-13 04:57:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-13 04:57:35]

Dry run: This issue passed the CQ dry run.

[mfomitchev, 2017-07-13 14:20:02]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-13 14:20:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mfomitchev, 2017-07-13 14:23:41]

Description was changed from

==========
.

BUG=
==========

to

==========
Make chrome --mus run the UI Service inside the browser process.

This CL takes advantage of the mechanisms introduced in
https://codereview.chromium.org/2979933002/ to run the UI Service inside the
browser process in Mushrome (i.e. when chrome is launched with --mus parameter).

UI Service runs on a separate thread with high priority. For now both the UI
Service and the GPU Service are moved. Once WS/GPU split if finished, GPU will
need to be moved into its separate process.

CrOS BrowserProcessPlatformPart owns the ImageCursorsSet used by the UI Service
for cursor manipulation.

BUG=722527
==========

[mfomitchev, 2017-07-13 14:24:35]

mfomitchev@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2017-07-13 16:08:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-13 16:08:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-07-13 17:23:22]

https://codereview.chromium.org/2983443002/diff/20002/chrome/browser/browser_...
File chrome/browser/browser_process_platform_part_chromeos.cc (right):

https://codereview.chromium.org/2983443002/diff/20002/chrome/browser/browser_...
chrome/browser/browser_process_platform_part_chromeos.cc:289:
service_manager::EmbeddedServiceInfo info;
Don't you only want to do this part for mus (not classic)?

[mfomitchev, 2017-07-13 18:06:36]

https://codereview.chromium.org/2983443002/diff/20002/chrome/browser/browser_...
File chrome/browser/browser_process_platform_part_chromeos.cc (right):

https://codereview.chromium.org/2983443002/diff/20002/chrome/browser/browser_...
chrome/browser/browser_process_platform_part_chromeos.cc:289:
service_manager::EmbeddedServiceInfo info;
On 2017/07/13 17:23:22, sky wrote:
> Don't you only want to do this part for mus (not classic)?

Good catch! Done.

[mfomitchev, 2017-07-13 18:09:33]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-13 18:09:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-13 19:54:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-13 19:54:24]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sky, 2017-07-13 20:37:21]

I'm LGTMing this, but it's also worth thinking about how we'll get ash to start
mus for the mash case. I don't want to hold up this review on that though.

https://codereview.chromium.org/2983443002/diff/50001/chrome/browser/browser_...
File chrome/browser/browser_process_platform_part_chromeos.cc (right):

https://codereview.chromium.org/2983443002/diff/50001/chrome/browser/browser_...
chrome/browser/browser_process_platform_part_chromeos.cc:288: if
(chromeos::GetAshConfig() == ash::Config::MUS) {
This certainly works for mushrome, but given we want mus to run in ash in mash
I'm wondering if this code should live in ash?

[mfomitchev, 2017-07-14 00:10:33]

The CQ bit was checked by mfomitchev@chromium.org

[commit-bot: I haz the power, 2017-07-14 00:11:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-14 00:11:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-14 00:11:03]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[mfomitchev, 2017-07-14 00:19:32]

On 2017/07/14 00:11:03, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet.
> CQ run can only be started once the patch has received an L-G-T-M from a full
> committer.
> Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
> full super star committer.
> Committers are members of the group "project-chromium-committers".
> Note that this has nothing to do with OWNERS files.

Oops. Scott, can you actually LGTM this please?

[sky, 2017-07-14 04:43:34]

LGTM for realz

[sky, 2017-07-14 04:43:41]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-07-14 04:43:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-14 06:03:47]

CQ is committing da patch.

Bot data: {"patchset_id": 70001, "attempt_start_ts": 1500007421366330,
"parent_rev": "397fe70fe94675f82c521d54374d79747465d2c7", "commit_rev":
"a872e762ddd650e53e093a4c68342eb637d5a931"}

[commit-bot: I haz the power, 2017-07-14 06:03:59]

Description was changed from

==========
Make chrome --mus run the UI Service inside the browser process.

This CL takes advantage of the mechanisms introduced in
https://codereview.chromium.org/2979933002/ to run the UI Service inside the
browser process in Mushrome (i.e. when chrome is launched with --mus parameter).

UI Service runs on a separate thread with high priority. For now both the UI
Service and the GPU Service are moved. Once WS/GPU split if finished, GPU will
need to be moved into its separate process.

CrOS BrowserProcessPlatformPart owns the ImageCursorsSet used by the UI Service
for cursor manipulation.

BUG=722527
==========

to

==========
Make chrome --mus run the UI Service inside the browser process.

This CL takes advantage of the mechanisms introduced in
https://codereview.chromium.org/2979933002/ to run the UI Service inside the
browser process in Mushrome (i.e. when chrome is launched with --mus parameter).

UI Service runs on a separate thread with high priority. For now both the UI
Service and the GPU Service are moved. Once WS/GPU split if finished, GPU will
need to be moved into its separate process.

CrOS BrowserProcessPlatformPart owns the ImageCursorsSet used by the UI Service
for cursor manipulation.

BUG=722527

Review-Url: https://codereview.chromium.org/2983443002
Cr-Commit-Position: refs/heads/master@{#486688}
Committed:
https://chromium.googlesource.com/chromium/src/+/a872e762ddd650e53e093a4c6834...
==========

[commit-bot: I haz the power, 2017-07-14 06:04:00]

Committed patchset #5 (id:70001) as
https://chromium.googlesource.com/chromium/src/+/a872e762ddd650e53e093a4c6834...