Issue 2983433002: Remove unused native methods ByteData_ToEndian<T>

Issue 2983433002: Remove unused native methods ByteData_ToEndian<T> (Closed)

Created:
3 years, 5 months ago by alexmarkov

Modified:
3 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google), zra, rmacnak, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Remove unused native methods ByteData_ToEndian<T> It seems like these native methods are defined in C++ code but not used from Dart code. This CL cleans them up. R=vegorov@google.com, zra@google.com Digging into history reveals that the following CL replaced these native methods with Dart implementation: https://codereview.chromium.org//860963002 Committed: https://github.com/dart-lang/sdk/commit/031533f04d9ad2578a9175b0de7a49b026d61a3c

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -124 lines)			Patch
	M	runtime/lib/typed_data.cc	View		1 chunk	+0 lines, -116 lines	0 comments	Download
	M	runtime/vm/bootstrap_natives.h	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Total messages: 6 (2 generated)

alexmarkov

3 years, 5 months ago (2017-07-13 17:08:51 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
031533f04d9ad2578a9175b0de7a49b026d61a3c (presubmit successful).