Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: runtime/lib/typed_data.cc

Issue 2983433002: Remove unused native methods ByteData_ToEndian<T> (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/typed_data.cc
diff --git a/runtime/lib/typed_data.cc b/runtime/lib/typed_data.cc
index 986c0357ae1be17a50484f9faa6df2d898a16e2e..19169b1538f5121e0b4ef7e7c5eaf792d34238fc 100644
--- a/runtime/lib/typed_data.cc
+++ b/runtime/lib/typed_data.cc
@@ -251,120 +251,4 @@ TYPED_DATA_NATIVES(Int32x4, Int32x4, New, value, 16, simd128_value_t)
TYPED_DATA_NATIVES(Float64x2, Float64x2, New, value, 16, simd128_value_t)
-DEFINE_NATIVE_ENTRY(ByteData_ToEndianInt16, 2) {
- GET_NON_NULL_NATIVE_ARGUMENT(Smi, host_value, arguments->NativeArgAt(0));
- GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
- int16_t value = host_value.Value();
- if (little_endian.value()) {
- value = Utils::HostToLittleEndian16(value);
- } else {
- value = Utils::HostToBigEndian16(value);
- }
- return Smi::New(value);
-}
-
-
-DEFINE_NATIVE_ENTRY(ByteData_ToEndianUint16, 2) {
- GET_NON_NULL_NATIVE_ARGUMENT(Smi, host_value, arguments->NativeArgAt(0));
- GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
- uint16_t value = host_value.Value();
- if (little_endian.value()) {
- return Smi::New(Utils::HostToLittleEndian16(value));
- }
- return Smi::New(Utils::HostToBigEndian16(value));
-}
-
-
-DEFINE_NATIVE_ENTRY(ByteData_ToEndianInt32, 2) {
- GET_NON_NULL_NATIVE_ARGUMENT(Integer, host_value, arguments->NativeArgAt(0));
- GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
- ASSERT((host_value.AsInt64Value() >= kMinInt32) ||
- (host_value.AsInt64Value() <= kMaxInt32));
- int32_t value = static_cast<int32_t>(host_value.AsInt64Value());
- if (little_endian.value()) {
- value = Utils::HostToLittleEndian32(value);
- } else {
- value = Utils::HostToBigEndian32(value);
- }
- return Integer::New(value);
-}
-
-
-DEFINE_NATIVE_ENTRY(ByteData_ToEndianUint32, 2) {
- GET_NON_NULL_NATIVE_ARGUMENT(Integer, host_value, arguments->NativeArgAt(0));
- GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
- ASSERT(host_value.AsInt64Value() <= kMaxUint32);
- uint32_t value = static_cast<uint32_t>(host_value.AsInt64Value());
- if (little_endian.value()) {
- value = Utils::HostToLittleEndian32(value);
- } else {
- value = Utils::HostToBigEndian32(value);
- }
- return Integer::New(value);
-}
-
-
-DEFINE_NATIVE_ENTRY(ByteData_ToEndianInt64, 2) {
- GET_NON_NULL_NATIVE_ARGUMENT(Integer, host_value, arguments->NativeArgAt(0));
- GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
- int64_t value = host_value.AsInt64Value();
- if (little_endian.value()) {
- value = Utils::HostToLittleEndian64(value);
- } else {
- value = Utils::HostToBigEndian64(value);
- }
- return Integer::New(value);
-}
-
-
-DEFINE_NATIVE_ENTRY(ByteData_ToEndianUint64, 2) {
- GET_NON_NULL_NATIVE_ARGUMENT(Integer, host_value, arguments->NativeArgAt(0));
- GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
- uint64_t value;
- if (host_value.IsBigint()) {
- const Bigint& bigint = Bigint::Cast(host_value);
- ASSERT(bigint.FitsIntoUint64());
- value = bigint.AsUint64Value();
- } else {
- ASSERT(host_value.IsMint() || host_value.IsSmi());
- value = host_value.AsInt64Value();
- }
- if (little_endian.value()) {
- value = Utils::HostToLittleEndian64(value);
- } else {
- value = Utils::HostToBigEndian64(value);
- }
- return Integer::NewFromUint64(value);
-}
-
-
-DEFINE_NATIVE_ENTRY(ByteData_ToEndianFloat32, 2) {
- GET_NON_NULL_NATIVE_ARGUMENT(Double, host_value, arguments->NativeArgAt(0));
- GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
- float value = host_value.value();
- if (little_endian.value()) {
- value =
- bit_cast<float>(Utils::HostToLittleEndian32(bit_cast<uint32_t>(value)));
- } else {
- value =
- bit_cast<float>(Utils::HostToBigEndian32(bit_cast<uint32_t>(value)));
- }
- return Double::New(value);
-}
-
-
-DEFINE_NATIVE_ENTRY(ByteData_ToEndianFloat64, 2) {
- GET_NON_NULL_NATIVE_ARGUMENT(Double, host_value, arguments->NativeArgAt(0));
- GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
- double value = host_value.value();
- if (little_endian.value()) {
- value = bit_cast<double>(
- Utils::HostToLittleEndian64(bit_cast<uint64_t>(value)));
- } else {
- value =
- bit_cast<double>(Utils::HostToBigEndian64(bit_cast<uint64_t>(value)));
- }
- return Double::New(value);
-}
-
} // namespace dart
« no previous file with comments | « no previous file | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698