Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2983203002: config_service: make UI adjustable for mobile (Closed)

Created:
3 years, 5 months ago by ayanaadylova
Modified:
3 years, 4 months ago
Reviewers:
Sergey Berezin, hinoka
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

config_service: make UI adjustable for mobile Changed percents to pixels in the width fields of paper cards and made UI adjustable for mobile. BUG=730832 Review-Url: https://codereview.chromium.org/2983203002 Committed: https://github.com/luci/luci-py/commit/421927b9bb0fa68f8b36394c5b12dc6aec3c0e2f

Patch Set 1 #

Patch Set 2 : config_service: prompt user to sign in when appropriate. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -64 lines) Patch
M appengine/components/tool_support/gae_sdk_utils.py View 1 3 chunks +42 lines, -8 lines 0 comments Download
M appengine/components/tools/gae.py View 1 1 chunk +14 lines, -0 lines 0 comments Download
M appengine/config_service/ui/common/auth-signin.html View 1 3 chunks +7 lines, -1 line 0 comments Download
M appengine/config_service/ui/src/config-ui/config-set.html View 1 8 chunks +64 lines, -29 lines 0 comments Download
M appengine/config_service/ui/src/config-ui/config-ui.html View 2 chunks +17 lines, -12 lines 0 comments Download
M appengine/config_service/ui/src/config-ui/front-page.html View 3 chunks +15 lines, -6 lines 0 comments Download
M appengine/config_service/ui/test/config-ui/config-set_test.html View 1 1 chunk +48 lines, -0 lines 0 comments Download
M appengine/swarming/server/task_request.py View 1 3 chunks +6 lines, -6 lines 0 comments Download
M appengine/swarming/server/task_request_test.py View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
ayanaadylova
PTAL
3 years, 5 months ago (2017-07-20 21:17:09 UTC) #2
Sergey Berezin
Code LGTM, though it would be nice to see it in action on a staging ...
3 years, 5 months ago (2017-07-21 01:12:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2983203002/1
3 years, 5 months ago (2017-07-21 18:04:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/377f25a60d559110)
3 years, 5 months ago (2017-07-21 18:07:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2983203002/1
3 years, 5 months ago (2017-07-21 21:25:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/luci-py/commit/421927b9bb0fa68f8b36394c5b12dc6aec3c0e2f
3 years, 5 months ago (2017-07-21 21:28:32 UTC) #12
ayanaadylova
On 2017/07/21 01:12:11, Sergey Berezin wrote: > Code LGTM, though it would be nice to ...
3 years, 5 months ago (2017-07-21 22:01:28 UTC) #13
Sergey Berezin
3 years, 4 months ago (2017-07-24 22:46:32 UTC) #14
Message was sent while issue was closed.
On 2017/07/21 22:01:28, ayanaadylova wrote:
> On 2017/07/21 01:12:11, Sergey Berezin wrote:
> > Code LGTM, though it would be nice to see it in action on a staging
instance.
> > Thanks!
> 
> My bad, sorry.
> Link to the staging version:
> https://2980-421927b-tainted-cwpayton-dot-luci-config.appspot.com

No worries, thanks for the link. This looks pretty cool!

Powered by Google App Engine
This is Rietveld 408576698