Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2983193002: Revert of Don't reset the omnibox state on command-return. (Closed)

Created:
3 years, 5 months ago by Justin Donnelly
Modified:
3 years, 5 months ago
CC:
chromium-reviews, jdonnelly+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't reset the omnibox state on command-return. (patchset #1 id:1 of https://codereview.chromium.org/2904243002/ ) Reason for revert: This change caused a new issue: https://crbug.com/743288. While we decide how to proceed, it would be better to revert to the previous behavior. Original issue's description: > Don't reset the omnibox state on command-return. > > This was originally added in https://codereview.chromium.org/260008/, > motivated it appears by a desire to match Safari's behavior. Safari no > longer does this (the address field state is preserved on command-return > as the new tab is openeed in the background). > > This change makes Chrome's behavior consistent with Safari, simplifies > the code, fixes a bug, and is more useful IMO. If you want to open > several tabs with variations on some search, for example, you can press > command-return after each, then keep typing to produce the next. > > See discussion in the bug for more info. > > BUG=513966 > > Review-Url: https://codereview.chromium.org/2904243002 > Cr-Commit-Position: refs/heads/master@{#475542} > Committed: https://chromium.googlesource.com/chromium/src/+/1f35c3ffdebd60917647555ac6ec572098967035 TBR=rohitrao@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=513966 Review-Url: https://codereview.chromium.org/2983193002 Cr-Commit-Position: refs/heads/master@{#488362} Committed: https://chromium.googlesource.com/chromium/src/+/01be2f3a17b5b274392a86dcfe9674af19b83564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Justin Donnelly
Created Revert of Don't reset the omnibox state on command-return.
3 years, 5 months ago (2017-07-20 19:19:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2983193002/1
3 years, 5 months ago (2017-07-20 19:19:46 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-20 19:47:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/01be2f3a17b5b274392a86dcfe96...

Powered by Google App Engine
This is Rietveld 408576698