Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2983153002: Make gitiles calls as Self instead of Anon (Closed)

Created:
3 years, 5 months ago by Ryan Tseng
Modified:
3 years, 5 months ago
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : WithScope #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M common/api/gitiles/gitiles.go View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
Ryan Tseng
3 years, 5 months ago (2017-07-20 01:27:44 UTC) #4
Ryan Tseng
Now with scopes!
3 years, 5 months ago (2017-07-20 03:57:45 UTC) #9
iannucci
lgtm
3 years, 5 months ago (2017-07-20 03:59:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2983153002/20001
3 years, 5 months ago (2017-07-20 04:01:17 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-07-20 04:06:21 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/c4c760eddc3c5075bdb36100a28e8d877d361543

Powered by Google App Engine
This is Rietveld 408576698