config_service: release the UI to the front page

config_service: release the UI to the front page

Added link to the APIs explorer in the header, removed /newui handler.

BUG=730832
Review-Url: https://codereview.chromium.org/2983103002
Committed: https://github.com/luci/luci-py/commit/c14fbd22e221ec137f85c90d403299ccc85d03c1

[ayanaadylova, 2017-07-19 20:49:42]

ayanaadylova@google.com changed reviewers:
+ hinoka@chromium.org, sergeyberezin@chromium.org

[ayanaadylova, 2017-07-19 20:49:43]

PTAL

[ayanaadylova, 2017-07-19 20:50:18]

On 2017/07/19 20:49:43, ayanaadylova wrote:
> PTAL

Link to the staging version:
https://2970-bb47aeb-tainted-ayanaadylova-dot-luci-config.appspot.com

[Ryan Tseng, 2017-07-19 22:41:16]

hinoka@google.com changed reviewers:
+ hinoka@google.com

[Ryan Tseng, 2017-07-19 22:41:17]

Also add a feedback button, instructions here:
https://chromium.googlesource.com/infra/infra/+/master/crdx/feedback

https://codereview.chromium.org/2983103002/diff/1/appengine/config_service/ui...
File appengine/config_service/ui/src/config-ui/front-page.html (right):

https://codereview.chromium.org/2983103002/diff/1/appengine/config_service/ui...
appengine/config_service/ui/src/config-ui/front-page.html:21: width: 550px;
This breaks on mobile (try narrowing the window).  
Check out:
https://www.w3schools.com/cssref/css3_pr_mediaquery.asp

768px is a common cutoff for mobile screens.

[Sergey Berezin, 2017-07-19 23:13:09]

I'd limit the scope of this CL even further - to just releasing it to '/' and
not touching anything else.

Move the percent-to-pixels change to another CL, since it apparently requires a
bit more finessing.

[ayanaadylova, 2017-07-19 23:28:08]

PTAL
I added feedback button and also made small changes to README from Sergey's
review.

https://codereview.chromium.org/2983103002/diff/1/appengine/config_service/ui...
File appengine/config_service/ui/src/config-ui/front-page.html (right):

https://codereview.chromium.org/2983103002/diff/1/appengine/config_service/ui...
appengine/config_service/ui/src/config-ui/front-page.html:21: width: 550px;
On 2017/07/19 22:41:17, Ryan Tseng wrote:
> This breaks on mobile (try narrowing the window).  
> Check out:
> https://www.w3schools.com/cssref/css3_pr_mediaquery.asp
> 
> 768px is a common cutoff for mobile screens.

I will do it in a separate CL like Sergey suggested.

[Sergey Berezin, 2017-07-20 04:01:37]

LGTM, and please update the CL description (remove "changed percents to
pixels...").

Thanks!

[ayanaadylova, 2017-07-20 04:04:30]

Description was changed from

==========
config_service: release the UI to the front page

Added link to the APIs explorer in the header, removed /newui handler, changed
percents to pixels in the width fields of paper cards.

BUG=730832
==========

to

==========
config_service: release the UI to the front page

Added link to the APIs explorer in the header, removed /newui handler.

BUG=730832
==========

[ayanaadylova, 2017-07-20 04:04:46]

The CQ bit was checked by ayanaadylova@google.com

[commit-bot: I haz the power, 2017-07-20 04:04:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-20 04:07:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1500523486758040,
"parent_rev": "650536bb4b4c8b1a6ecd58deb80df8be200fc19d", "commit_rev":
"c14fbd22e221ec137f85c90d403299ccc85d03c1"}

[commit-bot: I haz the power, 2017-07-20 04:07:08]

Description was changed from

==========
config_service: release the UI to the front page

Added link to the APIs explorer in the header, removed /newui handler.

BUG=730832
==========

to

==========
config_service: release the UI to the front page

Added link to the APIs explorer in the header, removed /newui handler.

BUG=730832

Review-Url: https://codereview.chromium.org/2983103002
Committed:
https://github.com/luci/luci-py/commit/c14fbd22e221ec137f85c90d403299ccc85d03c1
==========

[commit-bot: I haz the power, 2017-07-20 04:07:09]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/c14fbd22e221ec137f85c90d403299ccc85d03c1