Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2983093003: Revert of Add libc++ __tree to ubsan blacklist. (Closed)

Created:
3 years, 5 months ago by mbjorge
Modified:
3 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add libc++ __tree to ubsan blacklist. (patchset #2 id:20001 of https://codereview.chromium.org/2109663003/ ) Reason for revert: Issued fixed upstream Original issue's description: > Add libc++ __tree to ubsan blacklist. > > libc++ __tree is not ubsan clean. It floods compile and run steps > with "runtime error: downcast" and "runtime error: upcast" errors, > making ubsan much less usable. > This is a KI with libc++: https://llvm.org/bugs/show_bug.cgi?id=19302 > > Committed: https://crrev.com/e2abe2366d707ac6ad308e2643f41423971f81fc > Cr-Commit-Position: refs/heads/master@{#402902} TBR=dpranke@chromium.org,ochang@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2983093003 Cr-Commit-Position: refs/heads/master@{#487986} Committed: https://chromium.googlesource.com/chromium/src/+/a04bfdb5ee615dc24bb29a74e17409c4922e351a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M tools/ubsan/blacklist.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
mbjorge
Created Revert of Add libc++ __tree to ubsan blacklist.
3 years, 5 months ago (2017-07-19 20:40:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2983093003/1
3 years, 5 months ago (2017-07-19 20:40:26 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-07-19 20:40:29 UTC) #5
mbjorge
Tested compiling/running locally with the revert and didn't see the flood of runtime errors, so ...
3 years, 5 months ago (2017-07-19 20:40:55 UTC) #6
Nico
lgtm, nice, thanks!
3 years, 5 months ago (2017-07-19 20:45:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2983093003/1
3 years, 5 months ago (2017-07-19 20:45:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a04bfdb5ee615dc24bb29a74e17409c4922e351a
3 years, 5 months ago (2017-07-19 21:16:31 UTC) #12
Dirk Pranke
3 years, 5 months ago (2017-07-20 00:06:12 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698