Add option to install an ephemeral app to ChromeOS shelf context menu

chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
 
 #include "apps/app_window.h"
 #include "apps/app_window_registry.h"
 #include "apps/ui/native_app_window.h"
 #include "ash/ash_switches.h"
@@ skipping 613 matching lines @@
   // First app should be active again.
   EXPECT_EQ(ash::STATUS_ACTIVE, shelf_model()->ItemByID(item_id1)->status);
 
   // Close first app.
   CloseAppWindow(window1b);
   CloseAppWindow(window1);
   --item_count;
   EXPECT_EQ(item_count, shelf_model()->item_count());
 }
 
+// Verify that ChromeLauncherController::CanInstall() returns true for ephemeral
+// apps and false when the app is promoted to a regular installed app.
+IN_PROC_BROWSER_TEST_F(LauncherPlatformAppBrowserTest, InstallEphemeralApp) {
+  int item_count = shelf_model()->item_count();
+
+  // Sanity check to verify that ChromeLauncherController::CanInstall() returns
+  // false for apps that are fully installed.
+  const Extension* app = LoadAndLaunchPlatformApp("launch");
+  ASSERT_TRUE(app);
+  CreateAppWindow(app);
+  ++item_count;
+  ASSERT_EQ(item_count, shelf_model()->item_count());
+  const ash::ShelfItem& app_item = GetLastLauncherItem();
+  ash::ShelfID app_id = app_item.id;
+  EXPECT_FALSE(controller_->CanInstall(app_id));
+
+  // Add an ephemeral app.
+  const Extension* ephemeral_app = InstallEphemeralAppWithSourceAndFlags(
+      test_data_dir_.AppendASCII("platform_apps").AppendASCII("launch_2"),
+      1,
+      extensions::Manifest::INTERNAL,
+      Extension::NO_FLAGS);
+  ASSERT_TRUE(ephemeral_app);
+  CreateAppWindow(ephemeral_app);
+  ++item_count;
+  ASSERT_EQ(item_count, shelf_model()->item_count());
+  const ash::ShelfItem& ephemeral_item = GetLastLauncherItem();
+  ash::ShelfID ephemeral_id = ephemeral_item.id;
+
+  // Verify that the shelf item for the ephemeral app can be installed.
+  EXPECT_TRUE(controller_->CanInstall(ephemeral_id));
+
+  // Promote the ephemeral app to a regular installed app.
+  ExtensionService* service = extensions::ExtensionSystem::Get(profile())
+      ->extension_service();
+  service->PromoteEphemeralApp(ephemeral_app, false);

[tmdiep, 2014/05/28 03:25:42]

PromoteEphemeralApp() will be available when this patch makes it through the CQ:
https://codereview.chromium.org/297263003

+
+  // Verify that the shelf item for the app can no longer be installed.
+  EXPECT_FALSE(controller_->CanInstall(ephemeral_id));
+}
+
 // Confirm that Click behavior for app windows is correnct.
 IN_PROC_BROWSER_TEST_F(ShelfAppBrowserNoMinimizeOnClick, AppClickBehavior) {
   // Launch a platform app and create a window for it.
   const Extension* extension1 = LoadAndLaunchPlatformApp("launch");
   AppWindow* window1 = CreateAppWindow(extension1);
   EXPECT_TRUE(window1->GetNativeWindow()->IsVisible());
   EXPECT_TRUE(window1->GetBaseWindow()->IsActive());
   // Confirm that a controller item was created and is the correct state.
   const ash::ShelfItem& item1 = GetLastLauncherItem();
   LauncherItemController* item1_controller = GetItemController(item1.id);
@@ skipping 1437 matching lines @@
   // number of shelf items should increase.
   settings_manager->ShowChromePageForProfile(
       browser()->profile(),
       chrome::GetSettingsUrl(std::string()));
   Browser* settings_browser =
       settings_manager->FindBrowserForProfile(browser()->profile());
   ASSERT_TRUE(settings_browser);
   EXPECT_EQ(browser_count, NumberOfDetectedLauncherBrowsers(false));
   EXPECT_EQ(item_count + 1, shelf_model->item_count());
 }