Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: content/renderer/render_widget.cc

Issue 298283003: Add WasShown/WasHidden to RenderFrameObserver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add basic test on browser side. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 4eaa8ea995b67f5047fa169fee29041c5f8365b9..45d40539391f65c2418470323f5dc482bd21ed0e 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -768,6 +768,8 @@ void RenderWidget::OnWasHidden() {
TRACE_EVENT0("renderer", "RenderWidget::OnWasHidden");
// Go into a mode where we stop generating paint and scrolling events.
SetHidden(true);
+ FOR_EACH_OBSERVER(RenderFrameImpl, render_frames_,
+ WasHidden());
}
void RenderWidget::OnWasShown(bool needs_repainting) {
@@ -778,6 +780,8 @@ void RenderWidget::OnWasShown(bool needs_repainting) {
// See OnWasHidden
SetHidden(false);
+ FOR_EACH_OBSERVER(RenderFrameImpl, render_frames_,
+ WasShown());
if (!needs_repainting)
return;
@@ -2111,4 +2115,13 @@ void RenderWidget::UnregisterSwappedOutChildFrame(RenderFrameImpl* frame) {
swapped_out_frames_.RemoveObserver(frame);
}
+void RenderWidget::RegisterRenderFrame(RenderFrameImpl* frame) {
+ render_frames_.AddObserver(frame);
+}
+
+void RenderWidget::UnregisterRenderFrame(RenderFrameImpl* frame) {
+ render_frames_.RemoveObserver(frame);
+}
+
+
jam 2014/05/28 17:55:37 nit: extra line
nasko 2014/05/28 18:26:11 Done.
} // namespace content
« content/browser/frame_host/render_frame_host_impl.h ('K') | « content/renderer/render_widget.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698