Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: content/renderer/render_widget.cc

Issue 298283003: Add WasShown/WasHidden to RenderFrameObserver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add basic test on browser side. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_widget.h" 5 #include "content/renderer/render_widget.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/debug/trace_event.h" 10 #include "base/debug/trace_event.h"
(...skipping 750 matching lines...) Expand 10 before | Expand all | Expand 10 after
761 return; 761 return;
762 resizer_rect_ = resizer_rect; 762 resizer_rect_ = resizer_rect;
763 if (webwidget_) 763 if (webwidget_)
764 webwidget_->didChangeWindowResizerRect(); 764 webwidget_->didChangeWindowResizerRect();
765 } 765 }
766 766
767 void RenderWidget::OnWasHidden() { 767 void RenderWidget::OnWasHidden() {
768 TRACE_EVENT0("renderer", "RenderWidget::OnWasHidden"); 768 TRACE_EVENT0("renderer", "RenderWidget::OnWasHidden");
769 // Go into a mode where we stop generating paint and scrolling events. 769 // Go into a mode where we stop generating paint and scrolling events.
770 SetHidden(true); 770 SetHidden(true);
771 FOR_EACH_OBSERVER(RenderFrameImpl, render_frames_,
772 WasHidden());
771 } 773 }
772 774
773 void RenderWidget::OnWasShown(bool needs_repainting) { 775 void RenderWidget::OnWasShown(bool needs_repainting) {
774 TRACE_EVENT0("renderer", "RenderWidget::OnWasShown"); 776 TRACE_EVENT0("renderer", "RenderWidget::OnWasShown");
775 // During shutdown we can just ignore this message. 777 // During shutdown we can just ignore this message.
776 if (!webwidget_) 778 if (!webwidget_)
777 return; 779 return;
778 780
779 // See OnWasHidden 781 // See OnWasHidden
780 SetHidden(false); 782 SetHidden(false);
783 FOR_EACH_OBSERVER(RenderFrameImpl, render_frames_,
784 WasShown());
781 785
782 if (!needs_repainting) 786 if (!needs_repainting)
783 return; 787 return;
784 788
785 // Generate a full repaint. 789 // Generate a full repaint.
786 if (compositor_) 790 if (compositor_)
787 compositor_->SetNeedsForcedRedraw(); 791 compositor_->SetNeedsForcedRedraw();
788 scheduleComposite(); 792 scheduleComposite();
789 } 793 }
790 794
(...skipping 1313 matching lines...) Expand 10 before | Expand all | Expand 10 after
2104 } 2108 }
2105 2109
2106 void RenderWidget::RegisterSwappedOutChildFrame(RenderFrameImpl* frame) { 2110 void RenderWidget::RegisterSwappedOutChildFrame(RenderFrameImpl* frame) {
2107 swapped_out_frames_.AddObserver(frame); 2111 swapped_out_frames_.AddObserver(frame);
2108 } 2112 }
2109 2113
2110 void RenderWidget::UnregisterSwappedOutChildFrame(RenderFrameImpl* frame) { 2114 void RenderWidget::UnregisterSwappedOutChildFrame(RenderFrameImpl* frame) {
2111 swapped_out_frames_.RemoveObserver(frame); 2115 swapped_out_frames_.RemoveObserver(frame);
2112 } 2116 }
2113 2117
2118 void RenderWidget::RegisterRenderFrame(RenderFrameImpl* frame) {
2119 render_frames_.AddObserver(frame);
2120 }
2121
2122 void RenderWidget::UnregisterRenderFrame(RenderFrameImpl* frame) {
2123 render_frames_.RemoveObserver(frame);
2124 }
2125
2126
jam 2014/05/28 17:55:37 nit: extra line
nasko 2014/05/28 18:26:11 Done.
2114 } // namespace content 2127 } // namespace content
OLDNEW
« content/browser/frame_host/render_frame_host_impl.h ('K') | « content/renderer/render_widget.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698