Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2982783003: Use failedAt in more places (Closed)

Created:
3 years, 5 months ago by sra1
Modified:
3 years, 5 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use failedAt in more places I saw some inconsistency in one file so I did a global cleanup. BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/f4946f54e8a3b7c3a6b3fa8ddeea788654a74042

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -161 lines) Patch
M pkg/compiler/lib/src/closure.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/invariant.dart View 1 1 chunk +13 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js/js.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 5 chunks +6 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 4 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 8 chunks +8 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_mixins.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/env.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/kernel/native_basic_data.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/native/resolver.dart View 4 chunks +4 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/native/ssa.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 1 4 chunks +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 22 chunks +22 lines, -34 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +3 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 4 chunks +5 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_string_builder.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa_branch_builder.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/variable_allocator.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/selector.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
3 years, 5 months ago (2017-07-14 02:26:07 UTC) #2
Johnni Winther
lgtm
3 years, 5 months ago (2017-07-14 08:32:24 UTC) #4
sra1
3 years, 5 months ago (2017-07-14 19:11:16 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
f4946f54e8a3b7c3a6b3fa8ddeea788654a74042 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698