Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: pkg/compiler/lib/src/js_backend/enqueuer.dart

Issue 2982783003: Use failedAt in more places (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/constant_emitter.dart ('k') | pkg/compiler/lib/src/js_backend/namer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/enqueuer.dart
diff --git a/pkg/compiler/lib/src/js_backend/enqueuer.dart b/pkg/compiler/lib/src/js_backend/enqueuer.dart
index ee6500a3d0043f7cfc48a7d06bd4f789e139cbb2..5cb274c0cc223c822a91806abe7dd5640c9262d1 100644
--- a/pkg/compiler/lib/src/js_backend/enqueuer.dart
+++ b/pkg/compiler/lib/src/js_backend/enqueuer.dart
@@ -66,8 +66,7 @@ class CodegenEnqueuer extends EnqueuerImpl {
@override
void checkQueueIsEmpty() {
if (_queue.isNotEmpty) {
- throw new SpannableAssertionFailure(
- _queue.first.element, "$name queue is not empty.");
+ failedAt(_queue.first.element, "$name queue is not empty.");
}
}
@@ -83,8 +82,7 @@ class CodegenEnqueuer extends EnqueuerImpl {
if (workItem == null) return;
if (queueIsClosed) {
- throw new SpannableAssertionFailure(
- entity, "Codegen work list is closed. Trying to add $entity");
+ failedAt(entity, "Codegen work list is closed. Trying to add $entity");
}
applyImpact(listener.registerUsedElement(entity));
@@ -114,7 +112,7 @@ class CodegenEnqueuer extends EnqueuerImpl {
void checkClass(ClassEntity cls) {
_worldBuilder.processClassMembers(cls, (MemberEntity member, useSet) {
if (useSet.isNotEmpty) {
- throw new SpannableAssertionFailure(member,
+ failedAt(member,
'Unenqueued use of $member: ${useSet.iterable(MemberUse.values)}');
}
});
« no previous file with comments | « pkg/compiler/lib/src/js_backend/constant_emitter.dart ('k') | pkg/compiler/lib/src/js_backend/namer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698