Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2982773002: Add angular to analyzer plugin whitelist (Closed)

Created:
3 years, 5 months ago by mfairhurst
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/analysis_server/lib/src/plugin/plugin_manager.dart View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 7 (3 generated)
mfairhurst
3 years, 5 months ago (2017-07-13 19:33:57 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-07-13 20:32:25 UTC) #3
mfairhurst
Committed patchset #1 (id:1) manually as 2eb0017013c8a519468f6d6510d9c2e5367a79d0 (presubmit successful).
3 years, 5 months ago (2017-07-13 21:36:20 UTC) #5
Brian Wilkerson
3 years, 5 months ago (2017-07-19 20:10:05 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/2982773002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/plugin/plugin_manager.dart (right):

https://codereview.chromium.org/2982773002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/plugin/plugin_manager.dart:316:
'**angular/tools/analyzer_plugin')
I think this was suppose to be a replacement for the two lines above (unless you
need the old location to continue to work for a while).

Powered by Google App Engine
This is Rietveld 408576698