Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Side by Side Diff: pkg/analysis_server/lib/src/plugin/plugin_manager.dart

Issue 2982773002: Add angular to analyzer plugin whitelist (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 import 'dart:collection'; 6 import 'dart:collection';
7 import 'dart:convert'; 7 import 'dart:convert';
8 import 'dart:io' show Platform, Process, ProcessResult; 8 import 'dart:io' show Platform, Process, ProcessResult;
9 9
10 import 'package:analysis_server/src/plugin/notification_manager.dart'; 10 import 'package:analysis_server/src/plugin/notification_manager.dart';
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
304 304
305 /** 305 /**
306 * Initialize a newly created plugin manager. The notifications from the 306 * Initialize a newly created plugin manager. The notifications from the
307 * running plugins will be handled by the given [notificationManager]. 307 * running plugins will be handled by the given [notificationManager].
308 */ 308 */
309 PluginManager(this.resourceProvider, this.byteStorePath, this.sdkPath, 309 PluginManager(this.resourceProvider, this.byteStorePath, this.sdkPath,
310 this.notificationManager, this.instrumentationService) { 310 this.notificationManager, this.instrumentationService) {
311 // TODO(brianwilkerson) Figure out the right list of plugin paths. 311 // TODO(brianwilkerson) Figure out the right list of plugin paths.
312 _whitelistGlobs = <Glob>[ 312 _whitelistGlobs = <Glob>[
313 new Glob(resourceProvider.pathContext.separator, 313 new Glob(resourceProvider.pathContext.separator,
314 '**/angular_analyzer_plugin/tools/analyzer_plugin') 314 '**/angular_analyzer_plugin/tools/analyzer_plugin'),
315 new Glob(resourceProvider.pathContext.separator,
316 '**angular/tools/analyzer_plugin')
Brian Wilkerson 2017/07/19 20:10:05 I think this was suppose to be a replacement for t
315 ]; 317 ];
316 } 318 }
317 319
318 /** 320 /**
319 * Return a list of all of the plugins that are currently known. 321 * Return a list of all of the plugins that are currently known.
320 */ 322 */
321 @visibleForTesting 323 @visibleForTesting
322 List<PluginInfo> get plugins => _pluginMap.values.toList(); 324 List<PluginInfo> get plugins => _pluginMap.values.toList();
323 325
324 /** 326 /**
(...skipping 571 matching lines...) Expand 10 before | Expand all | Expand 10 after
896 * The completer that will be used to complete the future when the response is 898 * The completer that will be used to complete the future when the response is
897 * received from the plugin. 899 * received from the plugin.
898 */ 900 */
899 final Completer<Response> completer; 901 final Completer<Response> completer;
900 902
901 /** 903 /**
902 * Initialize a pending request. 904 * Initialize a pending request.
903 */ 905 */
904 _PendingRequest(this.method, this.requestTime, this.completer); 906 _PendingRequest(this.method, this.requestTime, this.completer);
905 } 907 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698