Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1615)

Unified Diff: telemetry/telemetry/internal/platform/cros_platform_backend.py

Issue 2982743002: webrtc: Fix missing port forwarding on CrOS (Closed)
Patch Set: webrtc: Fix missing port forwarding on CrOS and android Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/platform/cros_platform_backend.py
diff --git a/telemetry/telemetry/internal/platform/cros_platform_backend.py b/telemetry/telemetry/internal/platform/cros_platform_backend.py
index 01f2034bd0f30f078cf17b86677e414694a6b436..f85ab7a9cff96d64737adc929b160f727ab5b18f 100644
--- a/telemetry/telemetry/internal/platform/cros_platform_backend.py
+++ b/telemetry/telemetry/internal/platform/cros_platform_backend.py
@@ -55,6 +55,13 @@ class CrosPlatformBackend(
return port
return self._cri.GetRemotePort()
+ def CreatePortForwarder(self, port_pair, use_remote_port_forwarding=False):
+ return self.forwarder_factory.Create(port_pair, use_remote_port_forwarding)
+
+ def IsDeviceRemote(self):
+ # Check if CrOS device is remote
achuithb 2017/07/19 17:50:32 nit: period at the end of comment
cywang 2017/07/21 09:21:22 Done.
+ return self._cri and not self._cri.local
+
def IsThermallyThrottled(self):
raise NotImplementedError()

Powered by Google App Engine
This is Rietveld 408576698