Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: telemetry/telemetry/internal/platform/android_platform_backend.py

Issue 2982743002: webrtc: Fix missing port forwarding on CrOS (Closed)
Patch Set: webrtc: Fix missing port forwarding on CrOS and android Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/internal/forwarders/cros_forwarder.py ('k') | telemetry/telemetry/internal/platform/cros_platform_backend.py » ('j') | telemetry/telemetry/internal/platform/cros_platform_backend.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/platform/android_platform_backend.py
diff --git a/telemetry/telemetry/internal/platform/android_platform_backend.py b/telemetry/telemetry/internal/platform/android_platform_backend.py
index c01561ffacda693d3a0af0fe4b56a54a9cad8502..2c5b3f7759f7ca4c977f79b193bc29c181b55ce7 100644
--- a/telemetry/telemetry/internal/platform/android_platform_backend.py
+++ b/telemetry/telemetry/internal/platform/android_platform_backend.py
@@ -153,6 +153,15 @@ class AndroidPlatformBackend(
def GetRemotePort(self, port):
return forwarder.Forwarder.DevicePortForHostPort(port) or 0
+ def CreatePortForwarder(self, port_pair, use_remote_port_forwarding):
+ # use_remote_port_forwarding is ignored as it is always true for
+ # Android device.
+ return self.forwarder_factory.Create(port_pair)
+
+ def IsDeviceRemote(self):
+ # Android device is connected via adb which is on remote
achuithb 2017/07/19 17:50:32 nit: period at the end of comment.
cywang 2017/07/21 09:21:22 Done.
+ return True
+
def IsDisplayTracingSupported(self):
return bool(self.GetOSVersionName() >= 'J')
« no previous file with comments | « telemetry/telemetry/internal/forwarders/cros_forwarder.py ('k') | telemetry/telemetry/internal/platform/cros_platform_backend.py » ('j') | telemetry/telemetry/internal/platform/cros_platform_backend.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698