Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: LayoutTests/fast/dom/navigatorcontentutils/unregister-protocol-handler.html

Issue 298273008: Improve scheme validation check in NavigatorContentUtils (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/dom/navigatorcontentutils/unregister-protocol-handler.html
diff --git a/LayoutTests/fast/dom/navigatorcontentutils/unregister-protocol-handler.html b/LayoutTests/fast/dom/navigatorcontentutils/unregister-protocol-handler.html
index c56a2d6eeebaea225cbccb6e5b1310ce97543e2e..d930fd2c56f75a89e4f4a7f5e4b8bc0b44cdb372 100644
--- a/LayoutTests/fast/dom/navigatorcontentutils/unregister-protocol-handler.html
+++ b/LayoutTests/fast/dom/navigatorcontentutils/unregister-protocol-handler.html
@@ -53,15 +53,16 @@ var invalid_schemes = ['mailto:', 'ssh:/', 'magnet:+', 'tel:sip'];
invalid_schemes.forEach(function (scheme) {
var succeeded = false;
try {
- window.navigator.registerProtocolHandler(scheme, 'invalid scheme uri=%s', 'title');
+ window.navigator.unregisterProtocolHandler(scheme, 'invalid scheme uri=%s', 'title');
} catch (e) {
- succeeded = true;
+ succeeded = 'SyntaxError' == e.name;
+ errorMessage = e.message;
}
if (succeeded)
debug('Pass: Invalid scheme "' + scheme + '" falied.');
else
- debug('Fail: Invalid scheme "' + scheme + '" allowed.');
+ debug('Fail: Invalid scheme "' + scheme + '" allowed. Threw exception: "' + errorMessage + '".');
});
var invalid_urls = ["", "%S"];

Powered by Google App Engine
This is Rietveld 408576698