Issue 2982723002: Name-based approach to cross frame support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2982723002: Name-based approach to cross frame support.

Created:
3 years, 5 months ago by vsm

Modified:
3 years, 5 months ago

Reviewers:

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Name-based approach to cross frame support. This roughly follows the dart2js approach. If we see a JS object and no Dart type is installed as an extension on the prototype, search for an existing extension by name. See #28326

Patch Set 1 #

Total comments: 1

Created: 3 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -19 lines)			Patch
M	pkg/dev_compiler/lib/sdk/ddc_sdk.sum	View	Binary file		0 comments	Download
M	pkg/dev_compiler/test/not_yet_strong_tests.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart	View	4 chunks	+43 lines, -5 lines	0 comments	Download
M	tests/lib_strong/html/cross_frame_test.dart	View	3 chunks	+0 lines, -13 lines	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

vsm

3 years, 5 months ago (2017-07-14 15:35:27 UTC) #1

https://codereview.chromium.org/2982723002/diff/1/tests/lib_strong/html/cross...
File tests/lib_strong/html/cross_frame_test.dart (left):

https://codereview.chromium.org/2982723002/diff/1/tests/lib_strong/html/cross...
tests/lib_strong/html/cross_frame_test.dart:32: expect(() =>
frameWindow.document, throws);
Note - these are all static errors now.

Expand Messages | Collapse Messages