Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Unified Diff: tests/lib_strong/html/cross_frame_test.dart

Issue 2982723002: Name-based approach to cross frame support.
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib_strong/html/cross_frame_test.dart
diff --git a/tests/lib_strong/html/cross_frame_test.dart b/tests/lib_strong/html/cross_frame_test.dart
index 55b9e39dacf5b6916d9e106538c5340c73a107b2..6ca9ec1203731db6cae42f487299e927d2ef9164 100644
--- a/tests/lib_strong/html/cross_frame_test.dart
+++ b/tests/lib_strong/html/cross_frame_test.dart
@@ -27,14 +27,6 @@ main() {
// properly in dart2js instead of always returning true.
expect(frameWindow is! Window, isTrue);
expect(frameWindow.parent, isWindow);
-
- // Ensure that the frame's document is inaccessible via window.
- expect(() => frameWindow.document, throws);
vsm 2017/07/14 15:35:27 Note - these are all static errors now.
- });
-
- test('contentDocument', () {
- // Ensure that the frame's document is inaccessible.
- expect(() => iframe.contentDocument, throws);
});
test('location', () {
@@ -45,9 +37,6 @@ main() {
// expect(frameLocation, isNot(isLocation));
expect(frameLocation is! Location, isTrue);
- expect(() => frameLocation.href, throws);
- expect(() => frameLocation.hash, throws);
-
final frameParentLocation = iframe.contentWindow.parent.location;
expect(frameParentLocation, isLocation);
});
@@ -63,8 +52,6 @@ main() {
// Valid methods.
frameHistory.forward();
- expect(() => frameHistory.length, throws);
-
final frameParentHistory = iframe.contentWindow.parent.history;
expect(frameParentHistory, isHistory);
});
« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698