|
|
Created:
3 years, 5 months ago by yhirano Modified:
3 years, 5 months ago CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionSet "ping" requests priority as lowest
Requests from PingLoader had the lowest priority, but I changed it
unintentionally. This CL restores the original behavior.
BUG=739161
Review-Url: https://codereview.chromium.org/2982523002
Cr-Commit-Position: refs/heads/master@{#486267}
Committed: https://chromium.googlesource.com/chromium/src/+/7c45454f3655609e883505dc3269b2a6140302a6
Patch Set 1 #Patch Set 2 : fix #
Messages
Total messages: 27 (18 generated)
Description was changed from ========== Set "ping" requests priority as lowest BUG=739161 ========== to ========== Set "ping" requests priority as lowest Requests from PingLoader had the lowest priority, but I changed it unintentionally. This CL recovers the original behavior. BUG=739161 ==========
yhirano@chromium.org changed reviewers: + toyoshim@chromium.org
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Is it possible to add a unittest? (lgtm)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/07/12 07:12:46, kinuko wrote: > Is it possible to add a unittest? > I'm not sure if it's worth doing, but I did. It lacks a test for violation report because SendViolationReport doesn't have Keepalive. It is another bug, but I would like to fix this performance regression first.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/07/12 08:07:32, yhirano wrote: > On 2017/07/12 07:12:46, kinuko wrote: > > Is it possible to add a unittest? > > > > I'm not sure if it's worth doing, but I did. > It lacks a test for violation report because SendViolationReport doesn't have > Keepalive. It is another bug, but I would like to fix this performance > regression first. Thanks! (lgtm++)
On 2017/07/12 08:07:32, yhirano wrote: > On 2017/07/12 07:12:46, kinuko wrote: > > Is it possible to add a unittest? > > > > I'm not sure if it's worth doing, but I did. > It lacks a test for violation report because SendViolationReport doesn't have > Keepalive. It is another bug, but I would like to fix this performance > regression first. Thanks! (lgtm++)
The CQ bit was checked by yhirano@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by yhirano@chromium.org
Description was changed from ========== Set "ping" requests priority as lowest Requests from PingLoader had the lowest priority, but I changed it unintentionally. This CL recovers the original behavior. BUG=739161 ========== to ========== Set "ping" requests priority as lowest Requests from PingLoader had the lowest priority, but I changed it unintentionally. This CL restores the original behavior. BUG=739161 ==========
The CQ bit was checked by yhirano@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499918769466860, "parent_rev": "561aa07640b814fc95200bcd293548cd26946c32", "commit_rev": "28ac19b82c0a8f2d1d76816ba8b0367685c88cac"}
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499918769466860, "parent_rev": "4ec4e22309f16e9d46410e03f65445d848eb8541", "commit_rev": "1345b81d69b545c1a63421753a1d39d166220b68"}
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499918769466860, "parent_rev": "f3a47f5bad662d398829cbf96172ab112b50db8e", "commit_rev": "7c45454f3655609e883505dc3269b2a6140302a6"}
Message was sent while issue was closed.
Description was changed from ========== Set "ping" requests priority as lowest Requests from PingLoader had the lowest priority, but I changed it unintentionally. This CL restores the original behavior. BUG=739161 ========== to ========== Set "ping" requests priority as lowest Requests from PingLoader had the lowest priority, but I changed it unintentionally. This CL restores the original behavior. BUG=739161 Review-Url: https://codereview.chromium.org/2982523002 Cr-Commit-Position: refs/heads/master@{#486267} Committed: https://chromium.googlesource.com/chromium/src/+/7c45454f3655609e883505dc3269... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7c45454f3655609e883505dc3269...
Message was sent while issue was closed.
lgtm |