Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2982523002: Set "ping" requests priority as lowest (Closed)

Created:
3 years, 5 months ago by yhirano
Modified:
3 years, 5 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set "ping" requests priority as lowest Requests from PingLoader had the lowest priority, but I changed it unintentionally. This CL restores the original behavior. BUG=739161 Review-Url: https://codereview.chromium.org/2982523002 Cr-Commit-Position: refs/heads/master@{#486267} Committed: https://chromium.googlesource.com/chromium/src/+/7c45454f3655609e883505dc3269b2a6140302a6

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -2 lines) Patch
M third_party/WebKit/Source/core/loader/PingLoaderTest.cpp View 1 3 chunks +48 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (18 generated)
yhirano
3 years, 5 months ago (2017-07-12 06:23:54 UTC) #3
kinuko
Is it possible to add a unittest? (lgtm)
3 years, 5 months ago (2017-07-12 07:12:46 UTC) #6
yhirano
On 2017/07/12 07:12:46, kinuko wrote: > Is it possible to add a unittest? > I'm ...
3 years, 5 months ago (2017-07-12 08:07:32 UTC) #11
kinuko
On 2017/07/12 08:07:32, yhirano wrote: > On 2017/07/12 07:12:46, kinuko wrote: > > Is it ...
3 years, 5 months ago (2017-07-13 01:57:52 UTC) #14
kinuko
On 2017/07/12 08:07:32, yhirano wrote: > On 2017/07/12 07:12:46, kinuko wrote: > > Is it ...
3 years, 5 months ago (2017-07-13 01:57:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2982523002/20001
3 years, 5 months ago (2017-07-13 04:05:16 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2982523002/20001
3 years, 5 months ago (2017-07-13 04:06:33 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7c45454f3655609e883505dc3269b2a6140302a6
3 years, 5 months ago (2017-07-13 04:20:13 UTC) #26
tyoshino (SeeGerritForStatus)
3 years, 5 months ago (2017-07-13 04:39:38 UTC) #27
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698