Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2982513002: Remove dead code in ShapeResult::PositionForOffset (Closed)

Created:
3 years, 5 months ago by eae
Modified:
3 years, 5 months ago
Reviewers:
kojii
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead code in ShapeResult::PositionForOffset Variable 'x' is assigned a value that isn't used after the assignment. R=kojii@chromium.org Review-Url: https://codereview.chromium.org/2982513002 Cr-Commit-Position: refs/heads/master@{#485828} Committed: https://chromium.googlesource.com/chromium/src/+/90dc55dea70e9b4ad2f53d1da06719461d27efc4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
eae
3 years, 5 months ago (2017-07-11 23:04:38 UTC) #1
kojii
lgtm
3 years, 5 months ago (2017-07-12 02:58:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2982513002/1
3 years, 5 months ago (2017-07-12 02:58:19 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 04:05:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/90dc55dea70e9b4ad2f53d1da067...

Powered by Google App Engine
This is Rietveld 408576698