Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2982483002: Remove all calls to domAutomationController.setAutomationId. (Closed)

Created:
3 years, 5 months ago by Łukasz Anforowicz
Modified:
3 years, 5 months ago
Reviewers:
raymes
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all calls to domAutomationController.setAutomationId. These calls are no longer needed after r485461 (https://crrev.com/2478803003) which has made the domAutomationController.setAutomationId call a no-op. BUG=662543 This CL was uploaded by git cl split. R=raymes@chromium.org Review-Url: https://codereview.chromium.org/2982483002 Cr-Commit-Position: refs/heads/master@{#485790} Committed: https://chromium.googlesource.com/chromium/src/+/08a9521d2776ab1601fd6010ce055939cde43946

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unnecessary braces. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M ppapi/tests/test_case.html View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Łukasz Anforowicz
raymes@, can you PTAL?
3 years, 5 months ago (2017-07-11 23:53:13 UTC) #3
raymes
lgtm https://codereview.chromium.org/2982483002/diff/1/ppapi/tests/test_case.html File ppapi/tests/test_case.html (right): https://codereview.chromium.org/2982483002/diff/1/ppapi/tests/test_case.html#newcode171 ppapi/tests/test_case.html:171: if (window.domAutomationController) { nit: remove {}
3 years, 5 months ago (2017-07-11 23:55:36 UTC) #4
Łukasz Anforowicz
https://codereview.chromium.org/2982483002/diff/1/ppapi/tests/test_case.html File ppapi/tests/test_case.html (right): https://codereview.chromium.org/2982483002/diff/1/ppapi/tests/test_case.html#newcode171 ppapi/tests/test_case.html:171: if (window.domAutomationController) { On 2017/07/11 23:55:36, raymes wrote: > ...
3 years, 5 months ago (2017-07-12 00:00:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2982483002/20001
3 years, 5 months ago (2017-07-12 00:00:28 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 01:58:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/08a9521d2776ab1601fd6010ce05...

Powered by Google App Engine
This is Rietveld 408576698