Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Issue 2982473002: Remove all calls to domAutomationController.setAutomationId. (Closed)

Created:
3 years, 5 months ago by Łukasz Anforowicz
Modified:
3 years, 5 months ago
Reviewers:
boliu
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all calls to domAutomationController.setAutomationId. These calls are no longer needed after r485461 (https://crrev.com/2478803003) which has made the domAutomationController.setAutomationId call a no-op. BUG=662543 This CL was uploaded by git cl split. R=boliu@chromium.org Review-Url: https://codereview.chromium.org/2982473002 Cr-Commit-Position: refs/heads/master@{#485764} Committed: https://chromium.googlesource.com/chromium/src/+/9e11581c14be9b15a9ac690d6a62483fbb92abd8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M content/browser/security_exploit_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/site_per_process_browsertest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/zoom_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Łukasz Anforowicz
boliu@, PTAL?
3 years, 5 months ago (2017-07-11 23:45:27 UTC) #3
boliu
lgtm
3 years, 5 months ago (2017-07-11 23:54:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2982473002/1
3 years, 5 months ago (2017-07-11 23:58:26 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 01:25:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9e11581c14be9b15a9ac690d6a62...

Powered by Google App Engine
This is Rietveld 408576698