Resynthesize mixins from Kernel.

Resynthesize mixins from Kernel.

This adds Class.isSyntheticMixinImplementation flag which is set
to 'true' for synthetic X&Y classes.

R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/ebd3ed5adeb617b831ba22eeb5b611f299013ab5

[Siggi Cherem (dart-lang), 2017-07-21 16:46:43]

Please wait for Paul to review the analyzer changes.

kernel and fe changes lgtm (assuming you answer yes to my Q below). I still
would like Paul to take a second look at the fe changes as well.

https://codereview.chromium.org/2982373002/diff/1/pkg/kernel/lib/binary/ast_f...
File pkg/kernel/lib/binary/ast_from_binary.dart (right):

https://codereview.chromium.org/2982373002/diff/1/pkg/kernel/lib/binary/ast_f...
pkg/kernel/lib/binary/ast_from_binary.dart:467: int levelIndex = (flags >> 2) &
0x3;
just to double check - in C++ they don't need to deserialize the flags? (is that
why there is no corresponding change in the c++ side?)

[scheglov, 2017-07-21 16:49:37]

https://codereview.chromium.org/2982373002/diff/1/pkg/kernel/lib/binary/ast_f...
File pkg/kernel/lib/binary/ast_from_binary.dart (right):

https://codereview.chromium.org/2982373002/diff/1/pkg/kernel/lib/binary/ast_f...
pkg/kernel/lib/binary/ast_from_binary.dart:467: int levelIndex = (flags >> 2) &
0x3;
On 2017/07/21 16:46:43, Siggi Cherem (dart-lang) wrote:
> just to double check - in C++ they don't need to deserialize the flags? (is
that
> why there is no corresponding change in the c++ side?)

Correct. In C++ the code reads the byte and uses just one bit.
      case kIsAbstract:
        is_abstract_ = builder_->ReadBool();  // read is_abstract.
        if (++next_read_ == field) return;

[Paul Berry, 2017-07-21 17:11:12]

lgtm

[scheglov, 2017-07-21 17:29:51]

Description was changed from

==========
Resynthesize mixins from Kernel.

This adds Class.isSyntheticMixinImplementation flag which is set
to 'true' for synthetic X&Y classes.

R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Resynthesize mixins from Kernel.

This adds Class.isSyntheticMixinImplementation flag which is set
to 'true' for synthetic X&Y classes.

R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/ebd3ed5adeb617b831ba22eeb5b611f299013ab5
==========

[scheglov, 2017-07-21 17:29:53]

Committed patchset #1 (id:1) manually as
ebd3ed5adeb617b831ba22eeb5b611f299013ab5 (presubmit successful).