Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: pkg/kernel/lib/binary/ast_from_binary.dart

Issue 2982373002: Resynthesize mixins from Kernel. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/ast.dart ('k') | pkg/kernel/lib/binary/ast_to_binary.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/binary/ast_from_binary.dart
diff --git a/pkg/kernel/lib/binary/ast_from_binary.dart b/pkg/kernel/lib/binary/ast_from_binary.dart
index 3d556eb82bc75aead025532c4a3c49a00492c0ff..1e7f8762dad21bfac4914cee9da505ba20a35bdc 100644
--- a/pkg/kernel/lib/binary/ast_from_binary.dart
+++ b/pkg/kernel/lib/binary/ast_from_binary.dart
@@ -463,7 +463,8 @@ class BinaryBuilder {
node.fileEndOffset = readOffset();
int flags = readByte();
node.isAbstract = flags & 0x1 != 0;
- int levelIndex = (flags >> 1) & 0x3;
+ node.isSyntheticMixinImplementation = flags & 0x2 != 0;
+ int levelIndex = (flags >> 2) & 0x3;
Siggi Cherem (dart-lang) 2017/07/21 16:46:43 just to double check - in C++ they don't need to d
scheglov 2017/07/21 16:49:37 Correct. In C++ the code reads the byte and uses j
var level = ClassLevel.values[levelIndex + 1];
if (level.index >= node.level.index) {
node.level = level;
« no previous file with comments | « pkg/kernel/lib/ast.dart ('k') | pkg/kernel/lib/binary/ast_to_binary.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698