Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Issue 2982313002: [MarkersIntersectingRange #2.05] Add DocumentMarkerList::FirstMarkerIntersectingRange() (Closed)

Created:
3 years, 5 months ago by rlanday
Modified:
3 years, 5 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DocumentMarkerList::FirstMarkerIntersectingRange() We currently have a method DocumentMarkerList::MarkersIntersectingRange() that can be used to retrieve all the DocumentMarkers in the list intersecting a specified offset range. This CL adds another method to DocumentMarkerList, FirstMarkerIntersectingRange(), that can be used to more efficiently get just one marker when there may be multiple markers intersecting a given range. This method will be used to add the method DocumentMarkerController::FirstMarkerIntersectingOffsetRange() in another CL: https://codereview.chromium.org/2960473002 BUG=707867 Review-Url: https://codereview.chromium.org/2982313002 Cr-Commit-Position: refs/heads/master@{#488546} Committed: https://chromium.googlesource.com/chromium/src/+/66e56b31988d34ecefab5212c9daa897b31325e2

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comment to DMLEditor::FirstMarkerIntersectingRange() #

Total comments: 1

Patch Set 3 : Update comment #

Total comments: 1

Patch Set 4 : Update comment again #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/markers/ActiveSuggestionMarkerListImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/ActiveSuggestionMarkerListImpl.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/CompositionMarkerListImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/CompositionMarkerListImpl.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditorTest.cpp View 1 chunk +72 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 29 (18 generated)
rlanday
3 years, 5 months ago (2017-07-20 18:29:08 UTC) #4
Xiaocheng
lgtm with a nit https://codereview.chromium.org/2982313002/diff/1/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h File third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h (right): https://codereview.chromium.org/2982313002/diff/1/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h#newcode49 third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h:49: static DocumentMarker* FirstMarkerIntersectingRange(const MarkerList&, nit: ...
3 years, 5 months ago (2017-07-20 21:03:57 UTC) #5
rlanday
On 2017/07/20 at 21:03:57, xiaochengh wrote: > lgtm with a nit > > https://codereview.chromium.org/2982313002/diff/1/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h > ...
3 years, 5 months ago (2017-07-20 21:17:28 UTC) #9
Xiaocheng
https://codereview.chromium.org/2982313002/diff/20001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h File third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h (right): https://codereview.chromium.org/2982313002/diff/20001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h#newcode49 third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h:49: // Returns the first marker in the specified MarkerList ...
3 years, 5 months ago (2017-07-20 21:29:49 UTC) #11
rlanday
On 2017/07/20 at 21:29:49, xiaochengh wrote: > https://codereview.chromium.org/2982313002/diff/20001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h > File third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h (right): > > https://codereview.chromium.org/2982313002/diff/20001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h#newcode49 ...
3 years, 5 months ago (2017-07-20 22:05:39 UTC) #13
Xiaocheng
https://codereview.chromium.org/2982313002/diff/40001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h File third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h (right): https://codereview.chromium.org/2982313002/diff/40001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h#newcode36 third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h:36: // Returns the first marker that has non-empty overlap ...
3 years, 5 months ago (2017-07-20 22:07:27 UTC) #15
rlanday
On 2017/07/20 at 22:07:27, xiaochengh wrote: > https://codereview.chromium.org/2982313002/diff/40001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h > File third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h (right): > > https://codereview.chromium.org/2982313002/diff/40001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h#newcode36 ...
3 years, 5 months ago (2017-07-20 22:09:26 UTC) #16
Xiaocheng
Still lgtm. Thanks!
3 years, 5 months ago (2017-07-20 22:12:53 UTC) #17
yosin_UTC9
lgtm Thanks!
3 years, 5 months ago (2017-07-21 00:58:09 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2982313002/80001
3 years, 5 months ago (2017-07-21 01:46:58 UTC) #25
commit-bot: I haz the power
3 years, 5 months ago (2017-07-21 01:53:47 UTC) #29
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/66e56b31988d34ecefab5212c9da...

Powered by Google App Engine
This is Rietveld 408576698