Add DocumentMarkerList::FirstMarkerIntersectingRange()
We currently have a method DocumentMarkerList::MarkersIntersectingRange() that
can be used to retrieve all the DocumentMarkers in the list intersecting a
specified offset range. This CL adds another method to DocumentMarkerList,
FirstMarkerIntersectingRange(), that can be used to more efficiently get just
one marker when there may be multiple markers intersecting a given range.
This method will be used to add the method
DocumentMarkerController::FirstMarkerIntersectingOffsetRange() in another CL:
https://codereview.chromium.org/2960473002
BUG=707867
Review-Url: https://codereview.chromium.org/2982313002
Cr-Commit-Position: refs/heads/master@{#488546}
Committed: https://chromium.googlesource.com/chromium/src/+/66e56b31988d34ecefab5212c9daa897b31325e2
On 2017/07/20 at 21:03:57, xiaochengh wrote: > lgtm with a nit > > https://codereview.chromium.org/2982313002/diff/1/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h > ...
3 years, 5 months ago
(2017-07-20 21:17:28 UTC)
#9
https://codereview.chromium.org/2982313002/diff/20001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h File third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h (right): https://codereview.chromium.org/2982313002/diff/20001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h#newcode49 third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h:49: // Returns the first marker in the specified MarkerList ...
3 years, 5 months ago
(2017-07-20 21:29:49 UTC)
#11
https://codereview.chromium.org/2982313002/diff/40001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h File third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h (right): https://codereview.chromium.org/2982313002/diff/40001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h#newcode36 third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h:36: // Returns the first marker that has non-empty overlap ...
3 years, 5 months ago
(2017-07-20 22:07:27 UTC)
#15
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1500601611143720, "parent_rev": "f667ae6a0108972a65d6f6c1da968bc5a68e8220", "commit_rev": "b46cb6d6c7faa0ceddfd8bf764b24da989005b5e"}
3 years, 5 months ago
(2017-07-21 01:53:09 UTC)
#26
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1500601611143720,
"parent_rev": "f667ae6a0108972a65d6f6c1da968bc5a68e8220", "commit_rev":
"b46cb6d6c7faa0ceddfd8bf764b24da989005b5e"}
commit-bot: I haz the power
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1500601611143720, "parent_rev": "4ebe3ce03231bf5326ffeb2a6a656a22e3044484", "commit_rev": "66e56b31988d34ecefab5212c9daa897b31325e2"}
3 years, 5 months ago
(2017-07-21 01:53:29 UTC)
#27
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1500601611143720,
"parent_rev": "4ebe3ce03231bf5326ffeb2a6a656a22e3044484", "commit_rev":
"66e56b31988d34ecefab5212c9daa897b31325e2"}
commit-bot: I haz the power
Description was changed from ========== Add DocumentMarkerList::FirstMarkerIntersectingRange() We currently have a method DocumentMarkerList::MarkersIntersectingRange() that can ...
3 years, 5 months ago
(2017-07-21 01:53:45 UTC)
#28
Message was sent while issue was closed.
Description was changed from
==========
Add DocumentMarkerList::FirstMarkerIntersectingRange()
We currently have a method DocumentMarkerList::MarkersIntersectingRange() that
can be used to retrieve all the DocumentMarkers in the list intersecting a
specified offset range. This CL adds another method to DocumentMarkerList,
FirstMarkerIntersectingRange(), that can be used to more efficiently get just
one marker when there may be multiple markers intersecting a given range.
This method will be used to add the method
DocumentMarkerController::FirstMarkerIntersectingOffsetRange() in another CL:
https://codereview.chromium.org/2960473002
BUG=707867
==========
to
==========
Add DocumentMarkerList::FirstMarkerIntersectingRange()
We currently have a method DocumentMarkerList::MarkersIntersectingRange() that
can be used to retrieve all the DocumentMarkers in the list intersecting a
specified offset range. This CL adds another method to DocumentMarkerList,
FirstMarkerIntersectingRange(), that can be used to more efficiently get just
one marker when there may be multiple markers intersecting a given range.
This method will be used to add the method
DocumentMarkerController::FirstMarkerIntersectingOffsetRange() in another CL:
https://codereview.chromium.org/2960473002
BUG=707867
Review-Url: https://codereview.chromium.org/2982313002
Cr-Commit-Position: refs/heads/master@{#488546}
Committed:
https://chromium.googlesource.com/chromium/src/+/66e56b31988d34ecefab5212c9da...
==========
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/66e56b31988d34ecefab5212c9daa897b31325e2
3 years, 5 months ago
(2017-07-21 01:53:47 UTC)
#29
Issue 2982313002: [MarkersIntersectingRange #2.05] Add DocumentMarkerList::FirstMarkerIntersectingRange()
(Closed)
Created 3 years, 5 months ago by rlanday
Modified 3 years, 5 months ago
Reviewers: yosin_UTC9, Xiaocheng
Base URL:
Comments: 3