Checking in desugar into third_party

Checking in desugar into third_party

Desugar is a Google-developed open-source Java library used by the
build process to transform Java 8 bytecode to Java 7. It is used to
enable Java 8 features such as lambda experssions for Chrome on Android.

Our experiments show that Desugar outperforms Retrolambda in both APK
sizes and Java method counts. As of 2017 July, it is the official Java
8 support tool recognized by the Android team.

Also, creating a //third_party/bazel directory for checking in other
bazel components in the future.

BUG=730711
Review-Url: https://codereview.chromium.org/2982273002
Cr-Commit-Position: refs/heads/master@{#490503}
Committed: https://chromium.googlesource.com/chromium/src/+/17fc65188dfb708275491491edcf9d3be8cbb9af

[F, 2017-07-19 21:21:47]

Description was changed from

==========
Checking in desugar into third_party



BUG=730711
==========

to

==========
Checking in desugar into third_party

Desugar is a Google-developed open-source Java library used by the
build process to transform Java 8 bytecode to Java 7. It is used to
enable Java 8 features such as lambda experssions for Chrome on Android.

Our experiments show that Desugar outperforms Retrolambda in both APK
sizes and Java method counts. As of 2017 July, it is the official Java
8 support tool recognized by the Android team.

BUG=730711
==========

[F, 2017-07-19 21:23:34]

zpeng@chromium.org changed reviewers:
+ agrieve@chromium.org

[F, 2017-07-19 21:23:35]

Hi Andrew, PTAL. Thanks!

[agrieve, 2017-07-20 00:08:07]

https://codereview.chromium.org/2982273002/diff/1/third_party/desugar/README....
File third_party/desugar/README.chromium (right):

https://codereview.chromium.org/2982273002/diff/1/third_party/desugar/README....
third_party/desugar/README.chromium:22: blaze build --java_launcher
//third_party/java/jdk:jdk_launcher\
Using Bazel rather than blaze is fairly straight-forward. Please update
instructions (and prebuilt jar) to use bazel.

https://docs.bazel.build/versions/master/install.html

[F, 2017-07-20 18:02:41]

Thanks Andrew! PTAL

https://codereview.chromium.org/2982273002/diff/1/third_party/desugar/README....
File third_party/desugar/README.chromium (right):

https://codereview.chromium.org/2982273002/diff/1/third_party/desugar/README....
third_party/desugar/README.chromium:22: blaze build --java_launcher
//third_party/java/jdk:jdk_launcher\
On 2017/07/20 00:08:07, agrieve wrote:
> Using Bazel rather than blaze is fairly straight-forward. Please update
> instructions (and prebuilt jar) to use bazel.
> 
> https://docs.bazel.build/versions/master/install.html

Done.

[agrieve, 2017-07-20 18:15:05]

On 2017/07/20 18:02:41, F wrote:
> Thanks Andrew! PTAL
> 
>
https://codereview.chromium.org/2982273002/diff/1/third_party/desugar/README....
> File third_party/desugar/README.chromium (right):
> 
>
https://codereview.chromium.org/2982273002/diff/1/third_party/desugar/README....
> third_party/desugar/README.chromium:22: blaze build --java_launcher
> //third_party/java/jdk:jdk_launcher\
> On 2017/07/20 00:08:07, agrieve wrote:
> > Using Bazel rather than blaze is fairly straight-forward. Please update
> > instructions (and prebuilt jar) to use bazel.
> > 
> > https://docs.bazel.build/versions/master/install.html
> 
> Done.

lgtm

[F, 2017-07-20 18:16:32]

Description was changed from

==========
Checking in desugar into third_party

Desugar is a Google-developed open-source Java library used by the
build process to transform Java 8 bytecode to Java 7. It is used to
enable Java 8 features such as lambda experssions for Chrome on Android.

Our experiments show that Desugar outperforms Retrolambda in both APK
sizes and Java method counts. As of 2017 July, it is the official Java
8 support tool recognized by the Android team.

BUG=730711
==========

to

==========
Checking in desugar into third_party

Desugar is a Google-developed open-source Java library used by the
build process to transform Java 8 bytecode to Java 7. It is used to
enable Java 8 features such as lambda experssions for Chrome on Android.

Our experiments show that Desugar outperforms Retrolambda in both APK
sizes and Java method counts. As of 2017 July, it is the official Java
8 support tool recognized by the Android team.

Also, creating a //third_party/bazel directory for checking in other
bazel components in the future.

BUG=730711
==========

[palmer, 2017-07-26 18:58:43]

palmer@chromium.org changed reviewers:
+ palmer@chromium.org

[palmer, 2017-07-26 18:58:43]

lgtm

[xam, 2017-07-27 18:51:56]

On 2017/07/26 18:58:43, palmer wrote:
> lgtm

LGTM from OSTPR

[F, 2017-07-28 15:48:53]

zpeng@chromium.org changed reviewers:
+ thakis@chromium.org

[F, 2017-07-28 15:48:54]

+thakis@

Hi Nico, PTAL. Thanks!

I've also got LGTM from Jochen (eisinger@google / jochen@chromium) for chrome
eng review in the email threads. But I think now he only uses Gerrit for code
reviews.

[Nico, 2017-07-28 17:35:37]

lgtm assuming you have lg from legal as well. However, a question below:

https://codereview.chromium.org/2982273002/diff/20001/DEPS
File DEPS (right):

https://codereview.chromium.org/2982273002/diff/20001/DEPS#newcode1062
DEPS:1062: '-b', 'chromium-android-tools/retrolambda',
Are we going to remove this again?

https://codereview.chromium.org/2982273002/diff/20001/third_party/bazel/OWNERS
File third_party/bazel/OWNERS (right):

https://codereview.chromium.org/2982273002/diff/20001/third_party/bazel/OWNER...
third_party/bazel/OWNERS:2: zpeng@chromium.org
How much bazel stuff do you intend to add? Since we don't use bazel, it might be
preferable to have one third_party dir per bazel part we use.

[agrieve, 2017-07-28 17:42:45]

https://codereview.chromium.org/2982273002/diff/20001/third_party/bazel/OWNERS
File third_party/bazel/OWNERS (right):

https://codereview.chromium.org/2982273002/diff/20001/third_party/bazel/OWNER...
third_party/bazel/OWNERS:2: zpeng@chromium.org
On 2017/07/28 17:35:36, Nico (afk Wed Jul 26) wrote:
> How much bazel stuff do you intend to add? Since we don't use bazel, it might
be
> preferable to have one third_party dir per bazel part we use.

I asked to have the directory called Bazel. We already also use ijar from Bazel
(which I'll move under here), and I plan on pulling in a couple .jars from bazel
to improve our android resource build steps.

[Nico, 2017-07-28 17:44:10]

How many jars?

Can you add t_p/bazel/README.chromium to say that this contains components used
for building android binaries, but that we don't use bazel itself for the build?

[agrieve, 2017-07-28 17:52:55]

On 2017/07/28 17:44:10, Nico (afk Wed Jul 26) wrote:
> How many jars?
> 
> Can you add t_p/bazel/README.chromium to say that this contains components
used
> for building android binaries, but that we don't use bazel itself for the
build?

Bug is here: https://bugs.chromium.org/p/chromium/issues/detail?id=636448
Either 1 or 2 for resources (generally, logic from *Resource* here:
https://github.com/bazelbuild/bazel/blob/master/src/tools/android/java/com/go...)

[Nico, 2017-07-28 17:58:18]

On Fri, Jul 28, 2017 at 1:52 PM, <agrieve@chromium.org> wrote:

> On 2017/07/28 17:44:10, Nico (afk Wed Jul 26) wrote:
> > How many jars?
> >
> > Can you add t_p/bazel/README.chromium to say that this contains
> components
> used
> > for building android binaries, but that we don't use bazel itself for the
> build?
>
> Bug is here: https://bugs.chromium.org/p/chromium/issues/detail?id=636448
> Either 1 or 2 for resources (generally, logic from *Resource* here:
> https://github.com/bazelbuild/bazel/blob/master/src/tools/
> android/java/com/google/devtools/build/android/)
>

That sounds like a small-enough number to me that just having one dir per
jar sounds fine to me. But if you really want t_p/bazel, please add that
readme I mentioned.


>
> https://codereview.chromium.org/2982273002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[F, 2017-07-28 18:42:35]

Thanks Nico, PTAL!

I've added a README.chromium to /bazel. Also, yes, this CL has all necessary
third party approvals (I think legal is handled by OSTPR)

https://codereview.chromium.org/2982273002/diff/20001/DEPS
File DEPS (right):

https://codereview.chromium.org/2982273002/diff/20001/DEPS#newcode1062
DEPS:1062: '-b', 'chromium-android-tools/retrolambda',
On 2017/07/28 17:35:36, Nico (afk Wed Jul 26) wrote:
> Are we going to remove this again?

It will be removed in follow up CLs because currently there are teams actually
using retrolambda to backport some Java 8 libs, and removing retrolambda without
desugar will break their build

[Nico, 2017-07-28 18:43:25]

lgtm, thanks!

[F, 2017-07-28 18:44:03]

The CQ bit was checked by zpeng@chromium.org

[F, 2017-07-28 18:44:04]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org,
xam@google.com, agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2982273002/#ps40001
(title: "Adding Chromium.readme to bazel")

[commit-bot: I haz the power, 2017-07-28 18:44:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-28 20:45:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1501267443484920,
"parent_rev": "a1fa33f5f06cb27f39cf6240ca57854571f0b34e", "commit_rev":
"17fc65188dfb708275491491edcf9d3be8cbb9af"}

[commit-bot: I haz the power, 2017-07-28 20:45:41]

Description was changed from

==========
Checking in desugar into third_party

Desugar is a Google-developed open-source Java library used by the
build process to transform Java 8 bytecode to Java 7. It is used to
enable Java 8 features such as lambda experssions for Chrome on Android.

Our experiments show that Desugar outperforms Retrolambda in both APK
sizes and Java method counts. As of 2017 July, it is the official Java
8 support tool recognized by the Android team.

Also, creating a //third_party/bazel directory for checking in other
bazel components in the future.

BUG=730711
==========

to

==========
Checking in desugar into third_party

Desugar is a Google-developed open-source Java library used by the
build process to transform Java 8 bytecode to Java 7. It is used to
enable Java 8 features such as lambda experssions for Chrome on Android.

Our experiments show that Desugar outperforms Retrolambda in both APK
sizes and Java method counts. As of 2017 July, it is the official Java
8 support tool recognized by the Android team.

Also, creating a //third_party/bazel directory for checking in other
bazel components in the future.

BUG=730711

Review-Url: https://codereview.chromium.org/2982273002
Cr-Commit-Position: refs/heads/master@{#490503}
Committed:
https://chromium.googlesource.com/chromium/src/+/17fc65188dfb708275491491edcf...
==========

[commit-bot: I haz the power, 2017-07-28 20:45:43]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/17fc65188dfb708275491491edcf...