Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2982263002: DevTools: prepare migration for a batch of console tests (Closed)

Created:
3 years, 5 months ago by chenwilliam
Modified:
3 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: prepare migration for a batch of console tests Make our git diffs decent! Preparation for: https://chromium-review.googlesource.com/c/572164/ Bug=667560 Review-Url: https://codereview.chromium.org/2982263002 Cr-Commit-Position: refs/heads/master@{#488477} Committed: https://chromium.googlesource.com/chromium/src/+/277fb712260396a68fb6f74ccd53965f72decb50

Patch Set 1 #

Patch Set 2 : commit #

Patch Set 3 : \ #

Patch Set 4 : update test expects #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, --12 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-assert.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-assert-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-big-array.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-big-array-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-custom-formatters.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-custom-formatters-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-es6.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-es6-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dirxml.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dirxml-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-edit-expanded-tree.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-edit-expanded-tree-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-external-array.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-external-array-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-array-prototype.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-array-prototype-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-2.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-2-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-symbols-error.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-symbols-error-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-style.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-style-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-assert.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-big-array.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-dir.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-dirxml.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-edit-expanded-tree.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-external-array.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-array-prototype.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-es6.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-es6-2.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-es6-symbols-error.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-style.html View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
chenwilliam
Ptal. Need to use Rietveld b/c Gerrit's copy detection is not good. Changing the first ...
3 years, 5 months ago (2017-07-19 20:45:04 UTC) #4
dgozman
lgtm
3 years, 5 months ago (2017-07-19 21:21:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2982263002/40001
3 years, 5 months ago (2017-07-19 21:49:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/505161)
3 years, 5 months ago (2017-07-19 23:13:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2982263002/60001
3 years, 5 months ago (2017-07-20 20:54:49 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/505833)
3 years, 5 months ago (2017-07-20 22:22:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2982263002/60001
3 years, 5 months ago (2017-07-20 22:50:11 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-07-20 23:18:52 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/277fb712260396a68fb6f74ccd53...

Powered by Google App Engine
This is Rietveld 408576698