milo/buildsource/buildbot/pubsub_test.go - Issue 2982183002: Milo: Store console defs as their own entities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: milo/buildsource/buildbot/pubsub_test.go

Issue 2982183002: Milo: Store console defs as their own entities (Closed)

Patch Set: tests Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: milo/buildsource/buildbot/pubsub_test.go

diff --git a/milo/buildsource/buildbot/pubsub_test.go b/milo/buildsource/buildbot/pubsub_test.go

index 3952b099a2c28efd9c51a1f84f9d29e0a46b12e8..f02b6f03703b7a00077e6070f3aa9f4dbbb288d2 100644

--- a/milo/buildsource/buildbot/pubsub_test.go

+++ b/milo/buildsource/buildbot/pubsub_test.go

@@ -472,8 +472,6 @@ func TestPubSub(t *testing.T) {

})

So(h.Code, ShouldEqual, 200)

Convey("And stores correctly", func() {

- err := common.UpdateProjectConfigs(c)

Ryan Tseng 2017/07/19 19:51:02 This actually hasn't done anything useful for a wh

- So(err, ShouldBeNil)

c = auth.WithState(c, &authtest.FakeState{

Identity: "user:alicebob@google.com",

IdentityGroups: []string{"googlers", "all"},

« no previous file with comments | « milo/api/resp/build.go ('k') | milo/common/acl_test.go » ('j') | no next file with comments »