Milo: Store console defs as their own entities

milo/buildsource/buildbot/pubsub_test.go

 // Copyright 2016 The LUCI Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //      http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 454 matching lines @@
                         }
                         p := httprouter.Params{}
                         PubSubHandler(&router.Context{
                                 Context: c,
                                 Writer:  h,
                                 Request: r,
                                 Params:  p,
                         })
                         So(h.Code, ShouldEqual, 200)
                         Convey("And stores correctly", func() {
-                                err := common.UpdateProjectConfigs(c)

[Ryan Tseng, 2017/07/19 19:51:02]

This actually hasn't done anything useful for a while since we switch to using
cfgclient caching.

-                                So(err, ShouldBeNil)
                                 c = auth.WithState(c, &authtest.FakeState{
                                         Identity:       "user:alicebob@google.com",
                                         IdentityGroups: []string{"googlers", "all"},
                                 })
                                 loadB := &buildbotBuild{
                                         Master:      "Fake Master",
                                         Buildername: "Fake buildername",
                                         Number:      1234,
                                 }
                                 err = ds.Get(c, loadB)
                                 So(err, ShouldBeNil)
                                 So(loadB.Master, ShouldEqual, "Fake Master")
                                 So(loadB.Internal, ShouldEqual, true)
                                 So(loadB.Currentstep.(string), ShouldEqual, "this is a string")
                                 m, _, t, err := getMasterJSON(c, "Fake Master")
                                 So(err, ShouldBeNil)
                                 So(t.Unix(), ShouldEqual, 981173106)
                                 So(m.Name, ShouldEqual, "Fake Master")
                                 So(m.Project.Title, ShouldEqual, "some title")
                                 So(m.Slaves["testslave"].Name, ShouldEqual, "testslave")
                                 So(len(m.Slaves["testslave"].Runningbuilds), ShouldEqual, 0)
                                 So(len(m.Slaves["testslave"].RunningbuildsMap), ShouldEqual, 1)
                                 So(m.Slaves["testslave"].RunningbuildsMap["Fake buildername"][0],
                                         ShouldEqual, 2222)
                         })
                 })
         })
 }