Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2981843002: Tag default constructors in rasta (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M pkg/compiler/lib/src/kernel/kernel.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/kernel/visitor_test.dart View 3 chunks +5 lines, -5 lines 2 comments Download

Messages

Total messages: 7 (3 generated)
Johnni Winther
TBR
3 years, 5 months ago (2017-07-14 09:43:44 UTC) #3
Johnni Winther
Committed patchset #1 (id:1) manually as 5c46d9a243fd6749be3be85f829db3fc673e4c98 (presubmit successful).
3 years, 5 months ago (2017-07-14 09:44:07 UTC) #5
ahe
lgtm https://codereview.chromium.org/2981843002/diff/1/tests/compiler/dart2js/kernel/visitor_test.dart File tests/compiler/dart2js/kernel/visitor_test.dart (right): https://codereview.chromium.org/2981843002/diff/1/tests/compiler/dart2js/kernel/visitor_test.dart#newcode37 tests/compiler/dart2js/kernel/visitor_test.dart:37: // 'named_parameters', Issue 29853: default constructor _not expected ...
3 years, 5 months ago (2017-07-14 09:47:59 UTC) #6
Johnni Winther
3 years, 5 months ago (2017-07-14 10:15:04 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/2981843002/diff/1/tests/compiler/dart2js/kern...
File tests/compiler/dart2js/kernel/visitor_test.dart (right):

https://codereview.chromium.org/2981843002/diff/1/tests/compiler/dart2js/kern...
tests/compiler/dart2js/kernel/visitor_test.dart:37: // 'named_parameters', Issue
29853: default constructor _not expected
On 2017/07/14 09:47:59, ahe wrote:
> Why do you put underscores before not?

I meant to write _not_

Powered by Google App Engine
This is Rietveld 408576698