Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: tests/compiler/dart2js/kernel/visitor_test.dart

Issue 2981843002: Tag default constructors in rasta (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/kernel/visitor_test.dart
diff --git a/tests/compiler/dart2js/kernel/visitor_test.dart b/tests/compiler/dart2js/kernel/visitor_test.dart
index 661c134c1ceb4dd426d6ce66b8d634988c711887..c62fbd54482dcb822ad15901549e25bcd7d3ca51 100644
--- a/tests/compiler/dart2js/kernel/visitor_test.dart
+++ b/tests/compiler/dart2js/kernel/visitor_test.dart
@@ -23,7 +23,7 @@ import '../memory_compiler.dart';
const String TESTCASE_DIR = 'pkg/front_end/testcases/';
const List<String> TESTS = const <String>[
- 'DeltaBlue',
+ // 'DeltaBlue', Issue 29853: default constructor _not expected
'argument',
'arithmetic',
'async_function',
@@ -33,8 +33,8 @@ const List<String> TESTS = const <String>[
// 'covariant_generic', Issue 29853: typedefs
'escape',
'fallthrough',
- 'micro',
- 'named_parameters',
+ // 'micro', Issue 29853: Unexpected change in external methods
+ // 'named_parameters', Issue 29853: default constructor _not expected
ahe 2017/07/14 09:47:59 Why do you put underscores before not?
Johnni Winther 2017/07/14 10:15:04 I meant to write _not_
'null_aware',
// 'optional', Issue 29853: abstract members
'override',
@@ -43,9 +43,9 @@ const List<String> TESTS = const <String>[
'static_setter',
'store_load',
'stringliteral',
- 'uninitialized_fields',
+ // 'uninitialized_fields', Issue 29853: default constructor _not expected
'unused_methods',
- 'void-methods',
+ // 'void-methods', Issue 29853: unexpected change in []= encoding
];
main(List<String> arguments) {
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698