Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 2981833002: Revert of [tracing] Add heap profiler perftests. (Closed)

Created:
3 years, 5 months ago by mmenke
Modified:
3 years, 5 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org, kraynov
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [tracing] Add heap profiler perftests. (patchset #3 id:40001 of https://codereview.chromium.org/2976843002/ ) Reason for revert: This broke Win 64: https://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20Builder%20%28dbg%29&number=56316 Original issue's description: > [tracing] Add heap profiler perftests. > > This CL creates a generic place for heap profiler perftests, and adds > couple of stack frame deduplicator related perftests. > > BUG=739378 > > Review-Url: https://codereview.chromium.org/2976843002 > Cr-Commit-Position: refs/heads/master@{#486544} > Committed: https://chromium.googlesource.com/chromium/src/+/f43d398eac5c9d4c2bccda6d2630d108bbed1c99 TBR=primiano@chromium.org,dskiba@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=739378 Review-Url: https://codereview.chromium.org/2981833002 Cr-Commit-Position: refs/heads/master@{#486555} Committed: https://chromium.googlesource.com/chromium/src/+/19cbc1d36c775115307c12cc99a67770ee108eff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -159 lines) Patch
M components/tracing/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D components/tracing/test/heap_profiler_perftest.cc View 1 chunk +0 lines, -158 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
mmenke
Created Revert of [tracing] Add heap profiler perftests.
3 years, 5 months ago (2017-07-14 00:11:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2981833002/1
3 years, 5 months ago (2017-07-14 00:12:07 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-14 00:12:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/19cbc1d36c775115307c12cc99a6...

Powered by Google App Engine
This is Rietveld 408576698