Set 'isSyntheticDefault' for default constructors.

Set 'isSyntheticDefault' for default constructors.


R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/ebb3dea075e2602e271b7cf9b23863ac1a383fab

[Siggi Cherem (dart-lang), 2017-07-13 20:43:35]

lgtm

[Paul Berry, 2017-07-13 20:50:19]

lgtm

[scheglov, 2017-07-13 21:06:16]

Description was changed from

==========
Set 'isSyntheticDefault' for default constructors.


R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Set 'isSyntheticDefault' for default constructors.


R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/ebb3dea075e2602e271b7cf9b23863ac1a383fab
==========

[scheglov, 2017-07-13 21:06:19]

Committed patchset #1 (id:1) manually as
ebb3dea075e2602e271b7cf9b23863ac1a383fab (presubmit successful).

[Johnni Winther, 2017-07-14 09:21:59]

johnniwinther@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2017-07-14 09:22:03]

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/Del...
File pkg/front_end/testcases/DeltaBlue.dart.outline.expect (right):

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/Del...
pkg/front_end/testcases/DeltaBlue.dart.outline.expect:6: default constructor •()
→ void
Why isn't this change also in the .direct.expect file?

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/uni...
File pkg/front_end/testcases/uninitialized_fields.dart.outline.expect (right):

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/uni...
pkg/front_end/testcases/uninitialized_fields.dart.outline.expect:7: default
constructor •() → void
Why isn't this change also in the .direct.expect file?

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/voi...
File pkg/front_end/testcases/void-methods.dart.direct.expect (right):

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/voi...
pkg/front_end/testcases/void-methods.dart.direct.expect:11: return let final
dynamic #t1 = this.list in let final dynamic #t2 = 0 in let final dynamic #t3 =
x in let final dynamic #t4 = #t1.[]=(#t2, #t3) in #t3;
Why have these changed?

[ahe, 2017-07-14 09:42:26]

Thank you for doing this, Konstantin!

I think we need to roll back a few of the changes to golden files, but instead
of reviewing all the changes, I have an idea for automating it, and I'll send
out a CL later with the two things I've noticed so far and anything else I find.

With that caveat: LGTM!

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/Del...
File pkg/front_end/testcases/DeltaBlue.dart.outline.expect (right):

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/Del...
pkg/front_end/testcases/DeltaBlue.dart.outline.expect:6: default constructor •()
→ void
On 2017/07/14 09:22:02, Johnni Winther wrote:
> Why isn't this change also in the .direct.expect file?

It's probably because it already fails today, this is from compile.status:

DeltaBlue: Fail # Missing types on constructor parameters.

The direct.expect file is from dartk, and I need to go through them manually at
some point to ensure that there are no regressions.

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/cov...
File pkg/front_end/testcases/covariant_generic.dart.strong.expect (left):

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/cov...
pkg/front_end/testcases/covariant_generic.dart.strong.expect:18: set
mutableField$cc(core::Object mutableField_) → dynamic
I'm not sure this is correct. I think these are covariant bridge methods that
are needed to perform additional runtime checks. This is what Asger was working
on, and my understanding is that we planned to use that work.

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/uni...
File pkg/front_end/testcases/uninitialized_fields.dart.outline.expect (right):

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/uni...
pkg/front_end/testcases/uninitialized_fields.dart.outline.expect:7: default
constructor •() → void
On 2017/07/14 09:22:02, Johnni Winther wrote:
> Why isn't this change also in the .direct.expect file?

Same explanation.

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/voi...
File pkg/front_end/testcases/void-methods.dart.direct.expect (right):

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/voi...
pkg/front_end/testcases/void-methods.dart.direct.expect:11: return let final
dynamic #t1 = this.list in let final dynamic #t2 = 0 in let final dynamic #t3 =
x in let final dynamic #t4 = #t1.[]=(#t2, #t3) in #t3;
On 2017/07/14 09:22:02, Johnni Winther wrote:
> Why have these changed?

That's probably a mistake. The original version is correct (and originally from
dartk).

[Johnni Winther, 2017-07-14 10:13:52]

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/mic...
File pkg/front_end/testcases/micro.dart.direct.expect (right):

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/mic...
pkg/front_end/testcases/micro.dart.direct.expect:56: external static abstract
method externalStatic() → core::bool;
Why have these changed?

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/nam...
File pkg/front_end/testcases/named_parameters.dart.outline.expect (right):

https://codereview.chromium.org/2981783002/diff/1/pkg/front_end/testcases/nam...
pkg/front_end/testcases/named_parameters.dart.outline.expect:6: default
constructor •() → void
Why aren't these changes also in the .direct.expect file?

[ahe, 2017-07-14 12:56:49]

I think I've found all the changes that aren't related to adding "default", and
I've reverted them in the first patch set of this CL:
https://codereview.chromium.org/2981873002