Revert unrelated expectation changes.

Revert unrelated expectation changes.

This reverts a small fraction of ebb3dea075.

R=johnniwinther@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/c50abfb1c4913373f87896d27650e7fca4ed65dc

[ahe, 2017-07-14 13:00:26]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, scheglov@google.com

[ahe, 2017-07-14 13:00:27]

Here's the first raw patch set.

This is not yet ready for review as not all these changes should be reverted.
I'll go through them and send out another message when I have something ready
for review.

[ahe, 2017-07-14 13:15:30]

Patchset #2 (id:20001) has been deleted

[ahe, 2017-07-14 13:20:27]

OK, I think this is ready now. PTAL :-)

[scheglov, 2017-07-14 13:56:02]

LGTM

Sorry about these unresoled changes.

[Johnni Winther, 2017-07-17 07:27:24]

lgtm

https://codereview.chromium.org/2981873002/diff/80001/tests/compiler/dart2js/...
File tests/compiler/dart2js/kernel/visitor_test.dart (right):

https://codereview.chromium.org/2981873002/diff/80001/tests/compiler/dart2js/...
tests/compiler/dart2js/kernel/visitor_test.dart:26: // 'DeltaBlue', Issue 29853:
default constructor _not expected
Why are the expectations of 'DeltaBlue', 'named_parameters', and
'uninitialized_fields' not updated?

[ahe, 2017-07-17 08:34:41]

https://codereview.chromium.org/2981873002/diff/80001/tests/compiler/dart2js/...
File tests/compiler/dart2js/kernel/visitor_test.dart (right):

https://codereview.chromium.org/2981873002/diff/80001/tests/compiler/dart2js/...
tests/compiler/dart2js/kernel/visitor_test.dart:26: // 'DeltaBlue', Issue 29853:
default constructor _not expected
On 2017/07/17 07:27:24, Johnni Winther wrote:
> Why are the expectations of 'DeltaBlue', 'named_parameters', and
> 'uninitialized_fields' not updated?

I'm not sure what you're asking about. 

Let's focus on pkg/front_end/testcases/DeltaBlue.dart.direct.expect which hasn't
changed since I moved it from pkg/kernel. Fasta isn't generating the correct
output for that test and I've haven't gone through it to see how much is Fasta
being wrong, and how much is bad expectations.

[Johnni Winther, 2017-07-17 08:49:59]

https://codereview.chromium.org/2981873002/diff/80001/tests/compiler/dart2js/...
File tests/compiler/dart2js/kernel/visitor_test.dart (right):

https://codereview.chromium.org/2981873002/diff/80001/tests/compiler/dart2js/...
tests/compiler/dart2js/kernel/visitor_test.dart:26: // 'DeltaBlue', Issue 29853:
default constructor _not expected
On 2017/07/17 08:34:41, ahe wrote:
> On 2017/07/17 07:27:24, Johnni Winther wrote:
> > Why are the expectations of 'DeltaBlue', 'named_parameters', and
> > 'uninitialized_fields' not updated?
> 
> I'm not sure what you're asking about. 
> 
> Let's focus on pkg/front_end/testcases/DeltaBlue.dart.direct.expect which
hasn't
> changed since I moved it from pkg/kernel. Fasta isn't generating the correct
> output for that test and I've haven't gone through it to see how much is Fasta
> being wrong, and how much is bad expectations.

That answers my question :)

[ahe, 2017-07-17 10:11:10]

Description was changed from

==========
Revert unrelated expectation changes.

This reverts a small fraction of ebb3dea075.
==========

to

==========
Revert unrelated expectation changes.

This reverts a small fraction of ebb3dea075.

R=johnniwinther@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c50abfb1c4913373f87896d27650e7fca4ed65dc
==========

[ahe, 2017-07-17 10:11:12]

Committed patchset #4 (id:80001) manually as
c50abfb1c4913373f87896d27650e7fca4ed65dc (presubmit successful).