Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2981753002:
Gitiles: commit's author and committer are the same structures. (Closed)
|
Created:
3 years, 5 months ago by tandrii(chromium) Modified:
3 years, 5 months ago CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org Target Ref:
refs/heads/master Project:
luci-go Visibility:
Public. |
DescriptionGitiles: commit's author and committer are the same structures.
BUG=646067
Review-Url: https://codereview.chromium.org/2981753002
Committed: https://github.com/luci/luci-go/commit/b783a30c7cfed7b42d232fd37ce1f8950d6e731c
Patch Set 1 #
Total comments: 4
Patch Set 2 : review + bug #Messages
Total messages: 16 (10 generated)
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tandrii@chromium.org changed reviewers: + hinoka@chromium.org, iannucci@chromium.org
PTAL https://codereview.chromium.org/2981753002/diff/1/milo/common/gitiles/gitiles.go File milo/common/gitiles/gitiles.go (right): https://codereview.chromium.org/2981753002/diff/1/milo/common/gitiles/gitiles... milo/common/gitiles/gitiles.go:15: package gitiles I'm here to make use of this package from inside scheduler instead of existing misnamed "Gerrit" package https://cs.chromium.org/chromium/infra/go/src/github.com/luci/luci-go/schedul... Should I move the non-MILO specific part of this package this to a higher level common package first? If so, should this go to common/api?
may be worth having a dumping-ground bug for all the scheduler work just to keep it all together. https://codereview.chromium.org/2981753002/diff/1/milo/common/gitiles/gitiles.go File milo/common/gitiles/gitiles.go (right): https://codereview.chromium.org/2981753002/diff/1/milo/common/gitiles/gitiles... milo/common/gitiles/gitiles.go:15: package gitiles On 2017/07/13 19:08:48, tandrii(chromium) SLOW wrote: > I'm here to make use of this package from inside scheduler instead of existing > misnamed "Gerrit" package > https://cs.chromium.org/chromium/infra/go/src/github.com/luci/luci-go/schedul... > > Should I move the non-MILO specific part of this package this to a higher level > common package first? If so, should this go to common/api? common/api/gitiles seems fine to me. I would move it before or after this CL, doesn't really matter. https://codereview.chromium.org/2981753002/diff/1/milo/common/gitiles/gitiles... milo/common/gitiles/gitiles.go:39: type Author struct { User?
oh, and lgtm
Description was changed from ========== Gitiles: commit's author and committer are the same structures. BUG= ========== to ========== Gitiles: commit's author and committer are the same structures. BUG=646067 ==========
Ah, I have a bug, but forgot to add the first time. https://codereview.chromium.org/2981753002/diff/1/milo/common/gitiles/gitiles.go File milo/common/gitiles/gitiles.go (right): https://codereview.chromium.org/2981753002/diff/1/milo/common/gitiles/gitiles... milo/common/gitiles/gitiles.go:39: type Author struct { On 2017/07/13 19:14:36, iannucci wrote: > User? Done.
The CQ bit was checked by tandrii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from iannucci@chromium.org Link to the patchset: https://codereview.chromium.org/2981753002/#ps20001 (title: "review + bug")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499973683727670,
"parent_rev": "01276bd0fd73dd156838a56de1e76ccca49c4552", "commit_rev":
"b783a30c7cfed7b42d232fd37ce1f8950d6e731c"}
Message was sent while issue was closed.
Description was changed from ========== Gitiles: commit's author and committer are the same structures. BUG=646067 ========== to ========== Gitiles: commit's author and committer are the same structures. BUG=646067 Review-Url: https://codereview.chromium.org/2981753002 Committed: https://github.com/luci/luci-go/commit/b783a30c7cfed7b42d232fd37ce1f8950d6e731c ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://github.com/luci/luci-go/commit/b783a30c7cfed7b42d232fd37ce1f8950d6e731c |
